Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for DynamoDB queries in AppSync mapping templates #5861

Closed
1 of 2 tasks
duarten opened this issue Jan 18, 2020 · 1 comment · Fixed by #5940
Closed
1 of 2 tasks

Add support for DynamoDB queries in AppSync mapping templates #5861

duarten opened this issue Jan 18, 2020 · 1 comment · Fixed by #5940
Assignees
@MrArnoldPalmer
Labels
@aws-cdk/aws-appsync Related to AWS AppSync feature-request A feature should be added or improved. in-progress This issue is being actively worked on.

Comments

@duarten
Copy link
Contributor

duarten commented Jan 18, 2020

AppSync L2 constructs are missing some features which currently have to be hand-coded, namely support for DynamoDB queries.

This entails support for the query key conditions, as well as indexes and filters. We can (and should) start with the basics, with is support for key conditions.

Use Case

To avoid hand-coding AppSync resolvers which issue a DynamoDB query.

Proposed Solution

A possible API is:

${MappingTemplate.dynamoDbQuery(
  KeyCondition.eq("user", "user").and(
    KeyCondition.beginsWith("title", "startStr"))).renderTemplate()

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@duarten duarten added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 18, 2020
@SomayaB SomayaB added the @aws-cdk/aws-appsync Related to AWS AppSync label Jan 21, 2020
duarten added a commit to umani/aws-cdk that referenced this issue Jan 23, 2020
@duarten
feat(appsync): add support for mapping DynamoDB queries
7431496 
Add support to the L2 AppSync constructs for mapping DynamoDB queries.

Fixes aws#5861

Signed-off-by: Duarte Nunes <duarte@uma.ni>
duarten added a commit to umani/aws-cdk that referenced this issue Jan 23, 2020
@duarten
feat(appsync): add support for mapping DynamoDB queries
7e11115 
Add support to the L2 AppSync constructs for mapping DynamoDB queries.

Fixes aws#5861

Signed-off-by: Duarte Nunes <duarte@uma.ni>
@duarten duarten mentioned this issue Jan 23, 2020
Merged
@SomayaB SomayaB added in-progress This issue is being actively worked on. and removed needs-triage This issue or PR still needs to be triaged. labels Jan 23, 2020
@SomayaB
Copy link
Contributor

SomayaB commented Jan 23, 2020

Hi @duarten, thanks for putting in a PR, much appreciated! 👍

@SomayaB SomayaB assigned MrArnoldPalmer and unassigned shivlaks Jan 23, 2020
@duarten duarten mentioned this issue Jan 27, 2020
Closed
2 tasks
duarten added a commit to umani/aws-cdk that referenced this issue Feb 1, 2020
@duarten
feat(appsync): add support for mapping DynamoDB queries
c92200e 
Add support to the L2 AppSync constructs for mapping DynamoDB queries.

Fixes aws#5861

Signed-off-by: Duarte Nunes <duarte@uma.ni>
@mergify mergify bot closed this as completed in #5940 Feb 4, 2020
mergify bot pushed a commit that referenced this issue Feb 4, 2020
@duarten
feat(appsync): add support for mapping DynamoDB queries (#5940)
2240e97 
Add support to the L2 AppSync constructs for mapping DynamoDB queries.

Fixes #5861

Signed-off-by: Duarte Nunes <duarte@uma.ni>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrArnoldPalmer MrArnoldPalmer

Labels
@aws-cdk/aws-appsync Related to AWS AppSync feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(appsync): add support for mapping DynamoDB queries umani/aws-cdk
4 participants
@duarten @MrArnoldPalmer @SomayaB @shivlaks