Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the overrideArtifactName property on S3ArtifactsProps #5955

Closed
1 of 2 tasks
alexnikolis opened this issue Jan 25, 2020 · 3 comments · Fixed by #7384
Closed
1 of 2 tasks

Expose the overrideArtifactName property on S3ArtifactsProps #5955

alexnikolis opened this issue Jan 25, 2020 · 3 comments · Fixed by #7384
Assignees
@skinny85
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on.

Comments

@alexnikolis
Copy link

alexnikolis commented Jan 25, 2020 •
edited

Add the overrideArtifactName property to the S3ArtifactsProps interface.

Use Case

The overrideArtifactName property enables dynamically naming artifacts from the project's buildspec.

Proposed Solution

Include overrideArtifactName in the S3ArtifactsProps interface and include it in the compiled CloudFormation template.

Other

N/A

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@alexnikolis alexnikolis added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 25, 2020
@skinny85 skinny85 self-assigned this Jan 27, 2020
@skinny85 skinny85 added effort/small Small work item – less than a day of effort @aws-cdk/aws-codebuild Related to AWS CodeBuild and removed needs-triage This issue or PR still needs to be triaged. labels Jan 27, 2020
@skinny85
Copy link
Contributor

skinny85 commented Feb 6, 2020

Thanks for opening the issue @alexnikolis . Would you be interested in contributing this feature?

@shearn89
Copy link
Contributor

I'm having a quick stab at this as I've just hit the bug and would like the functionality. Hope to raise a PR soon.

@shearn89
Copy link
Contributor

Having trouble building and running my unit tests, probably because I'm on windows at the minute. I have a branch in my fork, just need to test it before raising a PR to make sure I've added a test in the right place!

@shearn89 shearn89 mentioned this issue Apr 16, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Apr 16, 2020
@mergify mergify bot closed this as completed in #7384 Apr 30, 2020
mergify bot pushed a commit that referenced this issue Apr 30, 2020
@shearn89
feat(codebuild): allow taking the artifact name from the buildspec
f7d3cd6 
This commit adds support for CodeBuild Artifacts to have names
controlled by a buildspec file, allowing the use of shell scripting to
sensibly name artifacts in CodeBuild projects generated from the CDK.
The previosuly required field `name` in `S3ArtifactsProps` is now optional,
and not providing it will set the `overrideArtifactName` on the underlying L1 to `true`.

Fixes #5955
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(codebuild): allow taking the artifact name from the buildspec
4 participants
@shearn89 @skinny85 @alexnikolis @SomayaB