fix(ecs-patterns): remove duplicate schedule property from scheduledTask constructs #6101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
iamhopaul123
force-pushed
the
ecs-patterns/remove-dup-schedule
branch
from
48cfbea
to
f174ad3
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
piradeepk
changed the title
|
Thank you for contributing! Your pull request is now being automatically merged. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request is now being automatically merged. |
floehopper
added a commit
to freerange/google-drive-backup
that referenced
this pull request
Mar 22, 2020
Importantly this includes a fix [1] which means we don't have to duplicate the schedule option in two places. [1]: aws/aws-cdk#6101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicated schedule, cluster, desiredTaskCount and vpc properties from scheduled task pattern (since those properties were defined and required but never used, it is not a breaking change).
Fixes #6076, fixes #5830
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license