Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support IPC and PID Mode with ECS TaskDefinition #7186

Closed
2 tasks
sdellwig opened this issue Apr 6, 2020 · 0 comments · Fixed by #7583 or bifravst/cloudformation-cleaner#13
Closed
2 tasks

Support IPC and PID Mode with ECS TaskDefinition #7186

sdellwig opened this issue Apr 6, 2020 · 0 comments · Fixed by #7583 or bifravst/cloudformation-cleaner#13
Assignees
@hossain-rayhan @piradeepk
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.

Comments

@sdellwig
Copy link

sdellwig commented Apr 6, 2020

The Elastic Container Service supports to set an IPC and PID Mode for a task definition. Unfortunately these parameters are not available via CDK.

Use Case

Running special Docker images e.g. APM agents in daemon mode.

Proposed Solution

Add also PID and IPC mode to the ECS TaskDefinitionProps data structure.

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@sdellwig sdellwig added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 6, 2020
@SomayaB SomayaB added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Apr 9, 2020
@SoManyHs SoManyHs added p2 good first issue Related to contributions. See CONTRIBUTING.md effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Apr 20, 2020
@piradeepk piradeepk self-assigned this Apr 22, 2020
@hossain-rayhan hossain-rayhan mentioned this issue Apr 23, 2020
Merged
@hossain-rayhan hossain-rayhan added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 23, 2020
@mergify mergify bot closed this as completed in #7583 Apr 27, 2020
mergify bot pushed a commit that referenced this issue Apr 27, 2020
@hossain-rayhan
feat(aws-ecs): add support for IPC and PID Mode for EC2 Task Definitions
1ee629e 
closes #7186

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@snyk-bot snyk-bot mentioned this issue May 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hossain-rayhan hossain-rayhan

@piradeepk piradeepk

Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Milestone
No milestone
6 participants
@uttarasridhar @hossain-rayhan @SomayaB @SoManyHs @piradeepk @sdellwig