fix(glue): DataFormat constants are not visible in non-JS languages #7458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constants on `DataFormat` were modelled as static properties on an interface, which is an invalid pattern in `jsii`. The `export const` declarations were in fact ignored by `jsii` at compilation, and the `namespace` declaration causes a conflict with the interface itself when the submodule feature is enabled on the codebase.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
NetaNir
approved these changes
Apr 21, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message
fix(glue): DataFormat constants are not visible in non-JS languages (#7458)
The constants on
DataFormatwere modelled as static properties on aninterface, which is an invalid pattern in
jsii. Theexport constdeclarations were in fact ignored by
jsiiat compilation, and thenamespacedeclaration causes a conflict with the interface itself whenthe submodule feature is enabled on the codebase.
End Commit Message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license