feat(core): move all types from "assets" to "core" #7708
Conversation
eladb
force-pushed
the
benisrae/refactor/assets
branch
from
f40af48
to
791c271
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Fold the "assets" module, which includes the Staging construct that takes care of staging asset files into the cloud assembly during synthesis into "core". This is in order to allow implementing custom resources that leverage assets throughout the framework. A subsequent commit will add a mini-framework for custom resources that leverages this capability.
eladb
force-pushed
the
benisrae/refactor/assets
branch
from
0747a66
to
fd8868f
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Curious about this mini-framework... |
| /** | ||
| * Symlink follow mode. | ||
| * @deprecated see `core.SymlinkFollowMode` | ||
| */ | ||
| export enum FollowMode { |
There was a problem hiding this comment.
Why not simply type alias or extend FollowMode, CopyOptions and FingerprintOptions with new ones added in core?
There was a problem hiding this comment.
Aliases are not respected by jsii
| @@ -0,0 +1,77 @@ | |||
| import * as cxapi from '@aws-cdk/cx-api'; | |||
There was a problem hiding this comment.
Why is this also not a move?
There was a problem hiding this comment.
Intentionally left the tests in the original module to ensure we maintain backwards compatibility.
eladb
changed the title
eladb
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Commit Message
feat(core): move all types from "assets" to "core" (#7708)
Fold the "assets" module, which includes the
Stagingconstruct that takes care of staging asset files into the cloud assembly during synthesis into "core". This is in order to allow implementing custom resources that leverage assets throughout the framework.NOTE: since interfaces in @aws-cdk/assets are used as based types for stable APIs, we are unable to fully deprecate this module within the codebase, so these types are left in tact and a compatibility layer was added.
A subsequent commit will add a mini-framework for custom resources that leverages this capability.
End Commit Message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license