fix(secretsmanager): rotation function name can exceed 64 chars #7896

jogold · 2020-05-10T09:36:26Z

Get the last 64 chars of the uniqueId.

Closes #7885
Closes #8442

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Get the last 64 chars of the `uniqueId`. See aws#7885 (comment). Closes aws#7885

jogold · 2020-05-10T09:51:12Z

packages/@aws-cdk/aws-secretsmanager/lib/secret-rotation.ts

+    // Max length of 64 chars, get the last 64 chars
+    const uniqueId = this.node.uniqueId;
+    const rotationFunctionName = uniqueId.substring(Math.max(uniqueId.length - 64, 0), uniqueId.length);


I wonder if something in @aws-cdk/core wouldn't be useful for such cases:

this.node.uniqueIdOf(50); // Custom length this.node.uniqueId64; // Last 64 chars

There are several places in the code where an id derived from unique id is truncated.

Or is this in constructs now?

A more general solution would be nice... and this is blocking me today. :(

aws-cdk-automation · 2020-05-10T10:20:00Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 0757125
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-06-03T06:47:20Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 189b203
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…truct-2

ahammond · 2020-06-07T02:19:09Z

packages/@aws-cdk/aws-secretsmanager/test/test.secret-rotation.ts

+            ],
+          ],
+        },
+        functionName: 'RotationSecretRotationSecretRotationSecretRotationSecretRotation',


Suggested change

functionName: 'RotationSecretRotationSecretRotationSecretRotationSecretRotation',

functionName: 'VeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongName',

I know the symmetry is pleasing, but it also makes it unnecessarily difficult to figure out how the name is generated.

Co-authored-by: Rico Huijbers <rix0rrr@gmail.com>

The PR aws#8403 changed the "IAM stack" to use the default environment and forgot to update the expected output (which now does not contain a token for the URL suffix). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

aws-cdk-automation · 2020-06-07T14:48:22Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 9e7b54a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-06-08T08:04:47Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 2b0ea5c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

skinny85

@jogold apologies for only now getting to review this. Would you mind rebasing/merging the PR with master? Looks like it accumulated some conflicts with mainline in the meantime. Thanks!

ahammond · 2020-06-08T22:05:00Z

@skinny85 I can't rebase his branch for him, but I did cherry-pick the only actual relevant change (everything else is merge noise) into #8442

Thank you for looking at this!

Pull request has been modified.

aws-cdk-automation · 2020-06-09T07:19:40Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 028281d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

jogold · 2020-06-09T07:45:03Z

@jogold apologies for only now getting to review this. Would you mind rebasing/merging the PR with master? Looks like it accumulated some conflicts with mainline in the meantime. Thanks!

Done (added a Closes #8442 in the PR body).

aws-cdk-automation · 2020-06-09T08:29:16Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 84460d2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-06-09T08:30:25Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 0a97ab0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

skinny85

LoveItLoveItLoveItLoveItLoveIt

Thanks @jogold !

mergify · 2020-06-10T00:28:47Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2020-06-10T01:16:15Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: c4b9d8d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2020-06-10T01:16:37Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

fix(secretsmanager): rotation function name exceeds 64 chars

0757125

Get the last 64 chars of the `uniqueId`. See aws#7885 (comment). Closes aws#7885

jogold commented May 10, 2020

View reviewed changes

SomayaB assigned skinny85 May 11, 2020

Merge branch 'master' into rotation-fn-name-length

189b203

Elad Ben-Israel and others added 4 commits June 4, 2020 15:47

real-synth

79bdb65

extract "real synth" to a separate file

137a32a

Merge remote-tracking branch 'origin/master' into benisrae/stage-cons…

8bdf8c5

…truct-2

Making the synthesis file a little nicer

43630e0

ahammond reviewed Jun 7, 2020

View reviewed changes

Elad Ben-Israel and others added 11 commits June 7, 2020 11:16

Merge branch 'master' into benisrae/stage-construct-2

853b46a

Update allowed-breaking-changes.txt

b811afd

touch ups

431490c

Co-authored-by: Rico Huijbers <rix0rrr@gmail.com>

update stack env description

420e6c9

assembly name validation & more tests

8a8951a

rename "embedded" to "nested" and move outdir resolution to app

94cc827

hoist runtimeInfo collection to assembly

711d861

update cx schema

2bb8e62

remove "experimental" annotation from Assembly

7715885

Merge branch 'master' into rotation-fn-name-length

9e7b54a

eladb force-pushed the master branch from 603c608 to 6407535 Compare June 7, 2020 18:03

Merge branch 'master' into rotation-fn-name-length

2b0ea5c

skinny85 previously requested changes Jun 8, 2020

View reviewed changes

Merge branch 'master' into rotation-fn-name-length

028281d

jogold added 2 commits June 9, 2020 09:42

fix conflict

84460d2

last conflict

0a97ab0

skinny85 approved these changes Jun 10, 2020

View reviewed changes

Merge branch 'master' into rotation-fn-name-length

c4b9d8d

mergify bot merged commit 24e474b into aws:master Jun 10, 2020

jogold deleted the rotation-fn-name-length branch June 18, 2020 11:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(secretsmanager): rotation function name can exceed 64 chars #7896

fix(secretsmanager): rotation function name can exceed 64 chars #7896

jogold commented May 10, 2020 •

edited

jogold May 10, 2020 •

edited

ahammond Jun 7, 2020

aws-cdk-automation commented May 10, 2020

aws-cdk-automation commented Jun 3, 2020

ahammond Jun 7, 2020

aws-cdk-automation commented Jun 7, 2020

aws-cdk-automation commented Jun 8, 2020

skinny85 left a comment

ahammond commented Jun 8, 2020

aws-cdk-automation commented Jun 9, 2020

jogold commented Jun 9, 2020

aws-cdk-automation commented Jun 9, 2020

aws-cdk-automation commented Jun 9, 2020

skinny85 left a comment

mergify bot commented Jun 10, 2020

aws-cdk-automation commented Jun 10, 2020

mergify bot commented Jun 10, 2020

	functionName: 'RotationSecretRotationSecretRotationSecretRotationSecretRotation',
	functionName: 'VeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongName',

fix(secretsmanager): rotation function name can exceed 64 chars #7896

fix(secretsmanager): rotation function name can exceed 64 chars #7896

Conversation

jogold commented May 10, 2020 • edited

jogold May 10, 2020 • edited

Choose a reason for hiding this comment

ahammond Jun 7, 2020

Choose a reason for hiding this comment

aws-cdk-automation commented May 10, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jun 3, 2020

AWS CodeBuild CI Report

ahammond Jun 7, 2020

Choose a reason for hiding this comment

aws-cdk-automation commented Jun 7, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jun 8, 2020

AWS CodeBuild CI Report

skinny85 left a comment

Choose a reason for hiding this comment

ahammond commented Jun 8, 2020

aws-cdk-automation commented Jun 9, 2020

AWS CodeBuild CI Report

jogold commented Jun 9, 2020

aws-cdk-automation commented Jun 9, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jun 9, 2020

AWS CodeBuild CI Report

skinny85 left a comment

Choose a reason for hiding this comment

mergify bot commented Jun 10, 2020

aws-cdk-automation commented Jun 10, 2020

AWS CodeBuild CI Report

mergify bot commented Jun 10, 2020

jogold commented May 10, 2020 •

edited

jogold May 10, 2020 •

edited