Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EnablePerformanceInsights to InstanceProps type #7957

Closed
2 tasks
adunne-resilient opened this issue May 13, 2020 · 1 comment · Fixed by #10092
Closed
2 tasks

Add EnablePerformanceInsights to InstanceProps type #7957

adunne-resilient opened this issue May 13, 2020 · 1 comment · Fixed by #10092
Assignees
@njlynch
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Milestone
[GA] RDS

Comments

@adunne-resilient
Copy link

Currently, there is no way to specify the EnablePerformanceInsights value for instances within a DatabaseCluster type (defaults to false). The alternative is to use the low-level Cfn types instead.

I am proposing supporting this configuration parameter on the InstanceProps type.

Use Case

I need to use this configuration parameter as part of a DatabaseCluster type, and I do not want to have to revert to using CfnDBCluster.

Proposed Solution

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@adunne-resilient adunne-resilient added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 13, 2020
@SomayaB SomayaB added the @aws-cdk/aws-rds Related to Amazon Relational Database label May 18, 2020
@nija-at
Copy link
Contributor

nija-at commented May 22, 2020

It seems we have two disjointed sets of properties InstanceProps and DatabaseInstanceProps.

An attempt to get re-organize these so one uses the other would help in keeping properties available in both DatabaseCluster and DatabaseInstance constructs.

@nija-at nija-at added effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels May 22, 2020
@skinny85 skinny85 added this to the RDS to 'stable' milestone Jul 8, 2020
@nija-at nija-at assigned skinny85 and unassigned nija-at Jul 14, 2020
njlynch added a commit that referenced this issue Sep 1, 2020
@njlynch
feat(rds): performance insights for DatabaseCluster instances
fbd653a 
Adds the EnablePerformanceInsights and related props to `InstanceProps` for
instances within a cluster.

_Note:_ I opted not to try to coalesce `InstanceProps`,
`DatabaseInstanceNewProps`, and `DatabaseInstanceSourceProps` in this PR; there
are a ton of overlapping properties, but it's not immediately clear which fields
are relevant for cluster instances vs standalone instances. I think
investigating and validiting how to combine these is a significantly larger
task.

fixes #7957
@njlynch njlynch mentioned this issue Sep 1, 2020
Merged
@njlynch njlynch assigned njlynch and unassigned skinny85 Sep 1, 2020
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Sep 1, 2020
@mergify mergify bot closed this as completed in #10092 Sep 2, 2020
mergify bot pushed a commit that referenced this issue Sep 2, 2020
@njlynch
feat(rds): performance insights for DatabaseCluster instances (#10092)
9c1b0c1 
Adds the EnablePerformanceInsights and related props to `InstanceProps` for
instances within a cluster.

_Note:_ I opted not to try to coalesce `InstanceProps`,
`DatabaseInstanceNewProps`, and `DatabaseInstanceSourceProps` in this PR; there
are a ton of overlapping properties, but it's not immediately clear which fields
are relevant for cluster instances vs standalone instances. I think
investigating and validiting how to combine these is a significantly larger
task.

fixes #7957

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njlynch njlynch

Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Projects
None yet
Milestone
[GA] RDS
Development

Successfully merging a pull request may close this issue.

feat(rds): performance insights for DatabaseCluster instances aws/aws-cdk
5 participants
@skinny85 @njlynch @nija-at @SomayaB @adunne-resilient