fix(lambda): SingletonFunction ignores explicit declared dependencies #7997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem here is that the Function construct underlying the SingletonFunction construct is attached directly to the Stack to enforce the Stack-wide singleton behaviour. This commit adds additional methods `addDependencies()` and `dependOn()` methods to let customers declare these. fixes #7568
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
RomainMuller
approved these changes
May 15, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
shivlaks
reviewed
May 16, 2020
| @@ -65,6 +65,22 @@ export class SingletonFunction extends FunctionBase { | |||
| return this.lambdaFunction.addPermission(name, permission); | |||
| } | |||
|
|
|||
| /** | |||
| * Using node.addDependency() does not work on this method as the underlying lambda function is modeled | |||
There was a problem hiding this comment.
does not work on this construct?
karupanerura
pushed a commit
to karupanerura/aws-cdk
that referenced
this pull request
May 22, 2020
…aws#7997) The problem here is that the Function construct underlying the SingletonFunction construct is attached directly to the Stack to enforce the Stack-wide singleton behaviour. This commit adds additional methods `addDependencies()` and `dependOn()` methods to let customers declare these. fixes aws#7568
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message
fix(lambda): SingletonFunction ignores explicit declared dependencies (#7997)
The problem here is that the Function construct underlying the
SingletonFunction construct is attached directly to the Stack to enforce
the Stack-wide singleton behaviour.
This commit adds additional methods
addDependencies()anddependOn()methods to let customers declare these.
fixes #7568
End Commit Message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license