fix(iot1click): incorrect type for Project.deviceTemplates #8000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Project.deviceTemplate` was patched to an incorrect type, accepting a single `DeviceTemplate` instance instead of a map of a template name to the corresponding `DeviceTemplate` instance. This replaces the patch with the appropriate value.
RomainMuller
added
bug
RomainMuller
added
the
pr-linter/exempt-test
RomainMuller
added
the
pr/do-not-merge
rix0rrr
approved these changes
May 15, 2020
RomainMuller
removed
the
pr/do-not-merge
shivlaks
approved these changes
May 15, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
karupanerura
pushed a commit
to karupanerura/aws-cdk
that referenced
this pull request
May 22, 2020
The `Project.deviceTemplate` had a `cfnspec` patch to an incorrect type, accepting a single `DeviceTemplate` instance instead of a map of a template name to the corresponding `DeviceTemplate` instance. This replaces the patch with the appropriate value. Fixes aws#8001
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message
fix(iot1click): incorrect type for Project.deviceTemplates (#8000)
The
Project.deviceTemplatehad acfnspecpatch to an incorrect type,accepting a single
DeviceTemplateinstance instead of a map of a templatename to the corresponding
DeviceTemplateinstance.This replaces the patch with the appropriate value.
Fixes #8001
End Commit Message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license