Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(batch): Invalid spot fleet service role #8325

Merged
merged 3 commits into from Jun 30, 2020
Merged

fix(batch): Invalid spot fleet service role #8325

merged 3 commits into from Jun 30, 2020

Conversation

cmckni3
Copy link
Contributor

@cmckni3 cmckni3 commented Jun 2, 2020

Generated role arn invalid due to missing colons (e.g. arnawsiam)

Closes #6706


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@cmckni3
Copy link
Contributor Author

cmckni3 commented Jun 2, 2020

Noticed when fixing code review comments for #8248

Generated role arn invalid due to missing colons (e.g. arnawsiam)

Closes #6706
@iliapolo
Copy link
Contributor

@cmckni3 Awesome, thanks for this!

@mergify
Copy link
Contributor

mergify bot commented Jun 30, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ec7d430
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 30, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 034bc35 into aws:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-batch compute-environment builds spot fleet role arn incorrectly
3 participants