Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EfsVolumeConfiguration to ecs.Volume #8448

Closed
1 of 2 tasks
simon-castano opened this issue Jun 9, 2020 · 0 comments · Fixed by #8467
Closed
1 of 2 tasks

Add EfsVolumeConfiguration to ecs.Volume #8448

simon-castano opened this issue Jun 9, 2020 · 0 comments · Fixed by #8467
Assignees
@uttarasridhar
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container feature-request A feature should be added or improved. in-progress This issue is being actively worked on.

Comments

@simon-castano
Copy link
Contributor

simon-castano commented Jun 9, 2020 •
edited

Add EfsVolumeConfiguration option to aws_ecs.Volume

Use Case

I need this feature to attach an EFS volume to a Fargate task defined with CDK

Proposed Solution

  1. Create an EfsVolumeConfiguration struct and aws_ecs.VolumeProperty CloudFormation Property Types similar to DockerVolumeConfiguration
  2. Add EfsVolumeConfiguration to the aws_ecs.Volume struct and aws_ecs.VolumeProperty CloudFormation Property Types
  3. Add EfsVolumeConfiguration parameter to addVolume method of aws_ecs.TaskDefinition

For the time being it shall be possible to use an AwsCustomResource calling aws_ecs.RegisterTaskDefinition, yet to be tested.

Other

Shall fix #6918

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@simon-castano simon-castano added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 9, 2020
@simon-castano simon-castano changed the title EfsVolumeConfiguration in TaskDefinition Add EfsVolumeConfiguration to ecs.Volume Jun 9, 2020
@simon-castano simon-castano mentioned this issue Jun 10, 2020
Merged
@SomayaB SomayaB added @aws-cdk/aws-ecs Related to Amazon Elastic Container in-progress This issue is being actively worked on. labels Jun 11, 2020
@SoManyHs SoManyHs removed the needs-triage This issue or PR still needs to be triaged. label Jun 15, 2020
@mergify mergify bot closed this as completed in #8467 Aug 18, 2020
mergify bot pushed a commit that referenced this issue Aug 18, 2020
@simon-castano
feat(ecs): add EfsVolumeConfiguration to Volume (#8467)
85ff9fd 
The PR is adding EfsVolumeConfiguration options to TaskDefinition as described on https://docs.aws.amazon.com/AmazonECS/latest/developerguide/efs-volumes.html#specify-efs-config

Full documentation is missing from CloudFormation documentation and is therefore not referenced.
While the unit test is passing, I haven't add the possibility to test this feature in practice.

fixes #6918
closes #8448

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
misterjoshua pushed a commit to misterjoshua/aws-cdk that referenced this issue Aug 19, 2020
@simon-castano @misterjoshua
feat(ecs): add EfsVolumeConfiguration to Volume (aws#8467)
b92e845 
The PR is adding EfsVolumeConfiguration options to TaskDefinition as described on https://docs.aws.amazon.com/AmazonECS/latest/developerguide/efs-volumes.html#specify-efs-config

Full documentation is missing from CloudFormation documentation and is therefore not referenced.
While the unit test is passing, I haven't add the possibility to test this feature in practice.

fixes aws#6918
closes aws#8448

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uttarasridhar uttarasridhar

Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ecs): add EfsVolumeConfiguration to Volume simon-castano/aws-cdk
4 participants
@uttarasridhar @SomayaB @SoManyHs @simon-castano