feat(cognito): user pool client - disable OAuth easily #8496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the defaults for the `UserPoolClient` sets up OAuth flows and scopes. If a user wishes to not use OAuth, they have to explicitly set a number of properties to `undefined` and use the escape hatch to control a property that does not have direct access at the L2 construct. See attached issue for details on how this is painful. A new property `disableOAuth` allows a user control this. closes #8429
nija-at
added
the
pr-linter/exempt-readme
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
RomainMuller
approved these changes
Jun 16, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the defaults for the
UserPoolClientsets up OAuth flows andscopes. If a user wishes to not use OAuth, they have to explicitly set
a number of properties to
undefinedand use the escape hatch tocontrol a property that does not have direct access at the L2 construct.
See attached issue for details on how this is painful.
A new property
disableOAuthallows a user control this.closes #8429
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license