feat(cfn-include): support logical id overrides #8529
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
skinny85
force-pushed
the
feat/cfn-include-cross-stack-refs
branch
from
abeafbe
to
287d48f
Compare
skinny85
changed the title
skinny85
added
the
pr-linter/exempt-readme
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -110,11 +122,11 @@ export class FromCloudFormation { | |||
| return ret; | |||
| } | |||
|
|
|||
| public static parseCreationPolicy(policy: any): CfnCreationPolicy | undefined { | |||
| public static parseCreationPolicy(policy: any, options: ParseCfnOptions): CfnCreationPolicy | undefined { | |||
There was a problem hiding this comment.
Passing around all the options everywhere feels a little dirty to me.
I'd think I'd prefer a class CfnParser or something which has the resolver as a member.
Not going to force you to change it, but I have a feeling it will be cleaner. Give it a thought.
There was a problem hiding this comment.
Done. @rix0rrr let me know if you like this way better.
…e template Previously, we created the Tokens needed for references like Ref and Fn::GetAtt without actually referencing the created L1s in the template, just by their logical IDs. That's not strictly correct, because users of CfnInclude can call overrideLogicalId() on the CloudFormation elements retrieved from the template, and we need to make sure to also reflect that in all references to that resource. Change the code converting from CloudFormation to CDK values to actually retrieve the appropriate L1 objects when encountering expressions like Ref and Fn::GetAtt. This also gives us correctly working cross-stack references for free. Related to aws#7375
skinny85
force-pushed
the
feat/cfn-include-cross-stack-refs
branch
from
287d48f
to
cb57a09
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
nija-at
changed the title
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
skinny85
added this to the "Migrating from CloudFormation to CDK" - Developer Preview milestone
Previously, we created the Tokens needed for references like
RefandFn::GetAttwithout actually referencing the created L1s in the template,
just by their logical IDs.
That's not strictly correct,
because users of
CfnIncludecan calloverrideLogicalId()on the CloudFormation elements retrieved from the template,
and we need to make sure to also reflect that in all references to that resource.
Change the code converting from CloudFormation to CDK values to actually retrieve
the appropriate L1 objects when encountering expressions like
RefandFn::GetAtt.This also gives us correctly working cross-stack references for free.
Related to #7375
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license