Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(efs): access point #8631

Merged
merged 24 commits into from
Jun 23, 2020
Merged

feat(efs): access point #8631

merged 24 commits into from
Jun 23, 2020

Conversation

pahud
Copy link
Contributor

@pahud pahud commented Jun 18, 2020 •
edited by nija-at

This PR adds the Amazon EFS Access Point construct support.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@pahud pahud mentioned this pull request Jun 18, 2020
Merged
@pahud
Copy link
Contributor Author

pahud commented Jun 18, 2020

The Lambda EFS support(#8602) depends on this PR. Please kindly review this PR before we can push the Lambda EFS PR forward. Thanks.

cc @nija-at @rix0rrr @eladb

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 37b0a53
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 7ff8390
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ddd2082
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 58f401a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

nija-at
nija-at previously requested changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this @pahud. Looks mostly good.

Some questions from me below around choice of defaults.

packages/@aws-cdk/aws-efs/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-efs/lib/access-point.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-efs/lib/access-point.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-efs/lib/access-point.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-efs/lib/access-point.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-efs/lib/access-point.ts Outdated Show resolved Hide resolved
@nija-at nija-at changed the title feat(efs): Add AccessPoint L2 construct feat(efs): access point Jun 19, 2020
@nija-at nija-at self-assigned this Jun 19, 2020
rix0rrr
rix0rrr reviewed Jun 19, 2020
View reviewed changes
packages/@aws-cdk/aws-efs/lib/access-point.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-efs/lib/access-point.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-efs/README.md Outdated Show resolved Hide resolved
@pahud
Update packages/@aws-cdk/aws-efs/lib/access-point.ts
318c7fd 
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@mergify mergify bot dismissed nija-at’s stale review June 19, 2020 09:15

Pull request has been modified.

@pahud
Update packages/@aws-cdk/aws-efs/lib/access-point.ts
dea65d2 
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 318c7fd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: dea65d2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 42cda88
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: f3368a2
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: f350efc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@pahud
Copy link
Contributor Author

pahud commented Jun 19, 2020

@nija-at @rix0rrr All comments addressed. Please check it out again.

pahud and others added 3 commits June 22, 2020 17:54
@pahud
Update packages/@aws-cdk/aws-efs/lib/access-point.ts
5313aa1 
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@pahud
Update packages/@aws-cdk/aws-efs/lib/access-point.ts
2efa35f 
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@pahud
Update packages/@aws-cdk/aws-efs/lib/access-point.ts
c920300 
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@mergify mergify bot dismissed nija-at’s stale review June 22, 2020 09:59

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d1a1712
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 5313aa1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 2efa35f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: c920300
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@pahud
Copy link
Contributor Author

pahud commented Jun 22, 2020

@nija-at all addressed issues in the comments are resolved. Please check it out again.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 279ecb9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 090def7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@pahud pahud requested a review from nija-at June 22, 2020 15:50
nija-at
nija-at reviewed Jun 23, 2020
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there @pahud. Couple of things below -

packages/@aws-cdk/aws-efs/lib/access-point.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-efs/lib/access-point.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-efs/lib/access-point.ts Outdated Show resolved Hide resolved
pahud and others added 2 commits June 23, 2020 18:51
@pahud
Update packages/@aws-cdk/aws-efs/lib/access-point.ts
04c800d 
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@pahud
fix
cf6409a
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 04c800d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: cf6409a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

nija-at
nija-at previously approved these changes Jun 23, 2020
View reviewed changes
@mergify mergify bot dismissed nija-at’s stale review June 23, 2020 13:49

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 3bd52db
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 23, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a4a158c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 23, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit dde0ef5 into aws:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nija-at nija-at nija-at approved these changes

@rix0rrr rix0rrr Awaiting requested review from rix0rrr

Assignees

@rix0rrr rix0rrr

@nija-at nija-at

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pahud @aws-cdk-automation @rix0rrr @nija-at