New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stepfunctions): class for working with Json paths to retrieve state machine data and context #8647
Conversation
merges the shared functionality of the `Data` and `Context` classes as there is overlap. From a user's perspective, working with paths is more idiomatic without having to think about state machine Data vs. task Context
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is not touching the inputPath
/outputPath
/resultPath
fields of state, and so does not offer a way to pass DISCARD
. Is that on purpose?
If nothing else, we can stick the public constant DISCARD on JsonPath
so that it becomes accessible over jsii... but I had hoped to fix the types there as well.
It was on purpose. I was planning on introducing it as a separate change initially. Given that we're here, I may as well do it as part of this PR |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
… 'Data' class (#8730) Motivation: We recently added the `JsonPath` class in #8647 However, re-work for Dynamo was in flight and added some classes that don't leverage the new class yet and `Data` has now been marked deprecated ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
merges the shared functionality of the
Data
andContext
classes as there is overlap.
From a user's perspective, working with paths is more idiomatic
without having to think about state machine Data vs. task Context
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license