Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stepfunctions): class for working with Json paths to retrieve state machine data and context #8647

Merged
merged 8 commits into from Jun 24, 2020

Conversation

shivlaks
Copy link
Contributor

merges the shared functionality of the Data and Context
classes as there is overlap.

From a user's perspective, working with paths is more idiomatic
without having to think about state machine Data vs. task Context


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

merges the shared functionality of the `Data` and `Context`
classes as there is overlap.

From a user's perspective, working with paths is more idiomatic
without having to think about state machine Data vs. task Context
@shivlaks shivlaks added the @aws-cdk/aws-stepfunctions Related to AWS StepFunctions label Jun 19, 2020
@shivlaks shivlaks requested review from rix0rrr, nija-at and a team June 19, 2020 07:13
@shivlaks shivlaks self-assigned this Jun 19, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 19, 2020
@shivlaks shivlaks changed the title feat(stepfunctions): new class for working with Json paths to retrieve state machine data and context feat(stepfunctions): class for working with Json paths to retrieve state machine data and context Jun 19, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 08e0d63
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 9993b95
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is not touching the inputPath/outputPath/resultPath fields of state, and so does not offer a way to pass DISCARD. Is that on purpose?

If nothing else, we can stick the public constant DISCARD on JsonPath so that it becomes accessible over jsii... but I had hoped to fix the types there as well.

@shivlaks
Copy link
Contributor Author

This PR is not touching the inputPath/outputPath/resultPath fields of state, and so does not offer a way to pass DISCARD. Is that on purpose?

If nothing else, we can stick the public constant DISCARD on JsonPath so that it becomes accessible over jsii... but I had hoped to fix the types there as well.

It was on purpose. I was planning on introducing it as a separate change initially. Given that we're here, I may as well do it as part of this PR

@nija-at nija-at removed their request for review June 24, 2020 10:55
@shivlaks shivlaks requested a review from rix0rrr June 24, 2020 17:37
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: eb847c4
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 33f0660
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: acac244
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 131c774
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 24, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 75c4bdf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 24, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 67978a1 into master Jun 24, 2020
@mergify mergify bot deleted the shivlaks/sfn-merge-data-context branch June 24, 2020 20:49
mergify bot pushed a commit that referenced this pull request Jun 25, 2020
… 'Data' class (#8730)

Motivation:

We recently added the `JsonPath` class in #8647 

However, re-work for Dynamo was in flight and added some classes that
don't leverage the  new class yet and `Data` has now been marked deprecated

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-stepfunctions Related to AWS StepFunctions contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants