Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@aws-cdk/aws-elasticloadbalancingv2] Unable to add multiple certificate for NLB (TLS) #8918

Closed
alluriv opened this issue Jul 7, 2020 · 2 comments · Fixed by #19289
Closed

[@aws-cdk/aws-elasticloadbalancingv2] Unable to add multiple certificate for NLB (TLS) #8918

alluriv opened this issue Jul 7, 2020 · 2 comments · Fixed by #19289
Assignees
@corymhall
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 bug This issue is a bug. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@alluriv
Copy link

alluriv commented Jul 7, 2020

I am able to manually add certificates in NLB Listener TLS:443 listener but when I try to add using below cdk it is throwing above error

const listener = this.service.loadBalancer.addListener('SecureListener', {
  port: 7443,
  defaultTargetGroups: [this.service.targetGroup],
  certificates: [
    {
      certificateArn: serverCertArn,
    },
    {
      certificateArn: serverCertArn1,
    },
    {
      certificateArn: serverCertArn2,
    },
  ],
});

Use Case

To add multiple certifcates to NLB listener.

Proposed Solution

Add addCertificate function in NLB like ALB for TLS listeners

This is a 🚀 Feature Request
@alluriv alluriv added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 7, 2020
@SomayaB SomayaB changed the title [aws-cdk/packages/@aws-cdk/aws-elasticloadbalancingv2/lib/nlb/network-listener.ts] Unable to add multiple certificate for NLB (TLS) [@aws-cdk/aws-elasticloadbalancingv2] Unable to add multiple certificate for NLB (TLS) Jul 7, 2020
@github-actions github-actions bot added the @aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 label Jul 7, 2020
@rix0rrr
Copy link
Contributor

rix0rrr commented Jul 8, 2020

What is it supposed to look like in CloudFormation?

@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md labels Jul 8, 2020
@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Jul 8, 2020
@rix0rrr rix0rrr added the p2 label Aug 12, 2020
@SomayaB SomayaB assigned njlynch and unassigned rix0rrr Aug 20, 2020
@corymhall corymhall self-assigned this Mar 8, 2022
@corymhall corymhall added bug This issue is a bug. and removed feature-request A feature should be added or improved. labels Mar 8, 2022
@corymhall corymhall mentioned this issue Mar 8, 2022
Merged
@mergify mergify bot closed this as completed in #19289 Mar 31, 2022
mergify bot pushed a commit that referenced this issue Mar 31, 2022
@corymhall
fix(elbv2): unable to add multiple certificates to NLB (#19289)
e8142e9 
This PR does a couple of things to update the NetworkListener to be on
par with ApplicationListener.

1. Add a NetworkListenerCertificate construct that allows you to
   associate multiple certificates with a listener.
2. Add a `addCertificates` method to `NetworkListener` similar to the
   same method on the `ApplicationListener`.

This is needed because even though the `certificates` property on a
`Listener`is an array, it expects only one certificate. To add more than
one you have to create an
`AWS::ElasticLoadBalancingV2::ListenerCertificate`. This functionality
was added to `ApplicationListner` via #13490.

fixes #8918, #15328

----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

StevePotter pushed a commit to StevePotter/aws-cdk that referenced this issue Apr 27, 2022
@corymhall
fix(elbv2): unable to add multiple certificates to NLB (aws#19289)
df6ca5b 
This PR does a couple of things to update the NetworkListener to be on
par with ApplicationListener.

1. Add a NetworkListenerCertificate construct that allows you to
   associate multiple certificates with a listener.
2. Add a `addCertificates` method to `NetworkListener` similar to the
   same method on the `ApplicationListener`.

This is needed because even though the `certificates` property on a
`Listener`is an array, it expects only one certificate. To add more than
one you have to create an
`AWS::ElasticLoadBalancingV2::ListenerCertificate`. This functionality
was added to `ApplicationListner` via aws#13490.

fixes aws#8918, aws#15328

----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corymhall corymhall

Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 bug This issue is a bug. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(elbv2): unable to add multiple certificates to NLB corymhall/aws-cdk
5 participants
@rix0rrr @njlynch @SomayaB @alluriv @corymhall