feat(lambda-nodejs): connection reuse with aws-sdk #9083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default Node.js HTTP/HTTPS agent creates a new TCP connection for every new request. To avoid the cost of establishing a new connection, configure the SDK for JavaScript to reuse TCP connections. For short-lived operations, such as DynamoDB queries, the latency overhead of setting up a TCP connection might be greater than the operation itself. See https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/node-reusing-connections.html
jogold
force-pushed
the
lambda-nodejs-connection-reuse
branch
from
2b24825
to
8de5106
Compare
jogold
force-pushed
the
lambda-nodejs-connection-reuse
branch
from
229eff7
to
2b24825
Compare
eladb
previously requested changes
Jul 16, 2020
| @@ -69,6 +69,9 @@ export class NodejsFunction extends lambda.Function { | |||
| }), | |||
| handler: `index.${handler}`, | |||
| }); | |||
|
|
|||
| // Enable connection reuse for aws-sdk | |||
| this.addEnvironment('AWS_NODEJS_CONNECTION_REUSE_ENABLED', '1'); | |||
There was a problem hiding this comment.
Feels like we need an opt-out option for this.
eladb
approved these changes
Jul 19, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Chriscbr
pushed a commit
to Chriscbr/aws-cdk
that referenced
this pull request
Jul 23, 2020
The default Node.js HTTP/HTTPS agent creates a new TCP connection for every new request. To avoid the cost of establishing a new connection, configure the SDK for JavaScript to reuse TCP connections. For short-lived operations, such as DynamoDB queries, the latency overhead of setting up a TCP connection might be greater than the operation itself. See https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/node-reusing-connections.html ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
curtiseppel
pushed a commit
to curtiseppel/aws-cdk
that referenced
this pull request
Aug 11, 2020
The default Node.js HTTP/HTTPS agent creates a new TCP connection for every new request. To avoid the cost of establishing a new connection, configure the SDK for JavaScript to reuse TCP connections. For short-lived operations, such as DynamoDB queries, the latency overhead of setting up a TCP connection might be greater than the operation itself. See https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/node-reusing-connections.html ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default Node.js HTTP/HTTPS agent creates a new TCP connection for
every new request. To avoid the cost of establishing a new connection,
configure the SDK for JavaScript to reuse TCP connections.
For short-lived operations, such as DynamoDB queries, the latency overhead of
setting up a TCP connection might be greater than the operation itself.
See https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/node-reusing-connections.html
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license