Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cdk-pipelines] SimpleSynthAction unable to set role or add policies to it. #9163

Closed
JeremyJonas opened this issue Jul 20, 2020 · 1 comment · Fixed by #9527
Closed

[cdk-pipelines] SimpleSynthAction unable to set role or add policies to it. #9163

JeremyJonas opened this issue Jul 20, 2020 · 1 comment · Fixed by #9527
Assignees
Labels
@aws-cdk/pipelines CDK Pipelines library effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2

Comments

@JeremyJonas
Copy link

constructor(private readonly props: SimpleSynthActionProps) {

Is there a way to set the role or add policies to it for SimpleSynthAction?

Currently when I create a new SimpleSynthAction, and even after it is bound, the actionProperties.role is always undefined. Additionally the props don't accept a role or policies to set during instatiation.

My synth action depends on getting permissions to a CodeArtifact repo (aws codeartifact login...).

Thank you!

@SomayaB SomayaB changed the title SimpleSynthAction unable to set role or add policies to it. [cdk-pipelines] SimpleSynthAction unable to set role or add policies to it. Jul 20, 2020
@SomayaB SomayaB added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Jul 20, 2020
@github-actions github-actions bot added the @aws-cdk/pipelines CDK Pipelines library label Jul 20, 2020
@ericzbeard ericzbeard removed the needs-triage This issue or PR still needs to be triaged. label Jul 20, 2020
@njlynch njlynch added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 and removed guidance Question that needs advice or information. labels Jul 31, 2020
@njlynch
Copy link
Contributor

njlynch commented Jul 31, 2020

Is there a way to set the role or add policies to it for SimpleSynthAction?

Not at this time. Marking this as a feature request; we could add an optional role to the SimpleSynthOptions to be used for the CodeBuild action. PRs welcome!

@ericzbeard ericzbeard removed their assignment Aug 3, 2020
luisantonioa added a commit to luisantonioa/aws-cdk that referenced this issue Aug 7, 2020
luisantonioa added a commit to luisantonioa/aws-cdk that referenced this issue Aug 7, 2020
luisantonioa added a commit to luisantonioa/aws-cdk that referenced this issue Aug 7, 2020
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Aug 8, 2020
@mergify mergify bot closed this as completed in #9527 Aug 18, 2020
mergify bot pushed a commit that referenced this issue Aug 18, 2020
Fixes #9163


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
misterjoshua pushed a commit to misterjoshua/aws-cdk that referenced this issue Aug 19, 2020
…9527)

Fixes aws#9163


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/pipelines CDK Pipelines library effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants