Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServerDeploymentGroup in Code deploy is accepting List of AutoScalingGroup instead of List of IAutoScalingGroup #9175

Closed
mohdarshad opened this issue Jul 20, 2020 · 3 comments · Fixed by #9252
Closed

ServerDeploymentGroup in Code deploy is accepting List of AutoScalingGroup instead of List of IAutoScalingGroup #9175

mohdarshad opened this issue Jul 20, 2020 · 3 comments · Fixed by #9252
Assignees
@skinny85
Labels
@aws-cdk/aws-codedeploy Related to AWS CodeDeploy effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1

Comments

@mohdarshad
Copy link

ServerDeploymentGroup in Code deploy is accepting List of AutoScalingGroup instead of IAutoScalingGroup.

There is no way to get hold of reference of a AutoscallingGroup by using its name, rather AutoScalingGroup.fromAutoScalingGroupName gives an instance of IAutoScalingGroup, which can not be casted into AutoScalingGroup

So, probably there is an oversight in ServerDeploymentGroup construct. This should most likely accept List of IAutoScalingGroup instead of List of AutoScalingGroup . Kindly confirm.
@skinny85 skinny85 self-assigned this Jul 20, 2020
@skinny85 skinny85 added @aws-cdk/aws-codedeploy Related to AWS CodeDeploy effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 labels Jul 20, 2020
@mohdarshad
Copy link
Author

Can we expect this in near future?

@skinny85
Copy link
Contributor

I'll try to work on this today @mohdarshad .

skinny85 added a commit to skinny85/aws-cdk that referenced this issue Jul 24, 2020
@skinny85
fix(codedeploy): ServerDeploymentGroup takes AutoScalingGroup instead…
ab717f2 
… of IAutoScalingGroup

Fixes aws#9175
@skinny85 skinny85 mentioned this issue Jul 24, 2020
Merged
@mohdarshad
Copy link
Author

Will it available anytime soon?

skinny85 added a commit to skinny85/aws-cdk that referenced this issue Aug 6, 2020
@skinny85
fix(codedeploy): ServerDeploymentGroup takes AutoScalingGroup instead…
defea62 
… of IAutoScalingGroup

Fixes aws#9175
skinny85 added a commit to skinny85/aws-cdk that referenced this issue Aug 7, 2020
@skinny85
fix(codedeploy): ServerDeploymentGroup takes AutoScalingGroup instead…
a891498 
… of IAutoScalingGroup

Fixes aws#9175
skinny85 added a commit to skinny85/aws-cdk that referenced this issue Aug 8, 2020
@skinny85
fix(codedeploy): ServerDeploymentGroup takes AutoScalingGroup instead…
7d3508e 
… of IAutoScalingGroup

Fixes aws#9175
@mergify mergify bot closed this as completed in #9252 Aug 8, 2020
mergify bot pushed a commit that referenced this issue Aug 8, 2020
@skinny85
fix(codedeploy): ServerDeploymentGroup takes AutoScalingGroup instead…
9ff55ae 
… of IAutoScalingGroup (#9252)

Fixes #9175

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
eladb pushed a commit that referenced this issue Aug 10, 2020
@skinny85
fix(codedeploy): ServerDeploymentGroup takes AutoScalingGroup instead…
a5f1eda 
… of IAutoScalingGroup (#9252)

Fixes #9175

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-codedeploy Related to AWS CodeDeploy effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
No milestone
2 participants
@skinny85 @mohdarshad