fix(cloudfront): Set MinimumProtocolVersion and SslSupportMethod when specifying distribution certificate #9200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when specifying distribution certificate Per the CloudFormation documentation, if you specify an ACM certificate ARN, you must also specify values for MinimumProtocolVersion and SslSupportMethod in AWS::CloudFront::Distribution ViewerCertificate. We are using the recommended SslSupportMethod of "sni-only" and default MinimumProtocolVersion of "TLSv1." Fixes: #9193
njlynch
reviewed
Jul 22, 2020
| @@ -221,6 +222,14 @@ export class Distribution extends Resource implements IDistribution { | |||
| }); | |||
| } | |||
|
|
|||
| private addViewerCertificate(certificate: acm.ICertificate): CfnDistribution.ViewerCertificateProperty { | |||
There was a problem hiding this comment.
Should be 'render' to match the other similar methods.
Suggested change
| private addViewerCertificate(certificate: acm.ICertificate): CfnDistribution.ViewerCertificateProperty { | |
| private renderViewerCertificate(certificate: acm.ICertificate): CfnDistribution.ViewerCertificateProperty { |
| return { | ||
| acmCertificateArn: certificate.certificateArn, | ||
| sslSupportMethod: SSLMethod.SNI, | ||
| minimumProtocolVersion: SecurityPolicyProtocol.TLS_V1, |
There was a problem hiding this comment.
(Nit) - I'd prefer we opt for a higher standard by default, per the docs:
We recommend that you specify TLSv1.2_2018 unless your viewers are using browsers or devices that don’t support TLSv1.2.
Given TLSv1.2 is supported now by all major browsers, I think it's a sane default here.
njlynch
reviewed
Jul 22, 2020
| @@ -3,6 +3,7 @@ import { Construct, IResource, Lazy, Resource, Stack, Token, Duration } from '@a | |||
| import { CfnDistribution } from './cloudfront.generated'; | |||
| import { Origin } from './origin'; | |||
| import { CacheBehavior } from './private/cache-behavior'; | |||
| import { SSLMethod, SecurityPolicyProtocol } from './web_distribution'; | |||
There was a problem hiding this comment.
One more thing -- I've been incrementally moving these sorts of common enums from './web_distribution' to this file, as the (very long-term) plan is to deprecate web_distribution in favor of this construct. Bonus points if you move these two over as part of this change. :D
njlynch
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Chriscbr
pushed a commit
to Chriscbr/aws-cdk
that referenced
this pull request
Jul 23, 2020
… specifying distribution certificate (aws#9200) Per the CloudFormation documentation, if you specify an ACM certificate ARN, you must also specify values for MinimumProtocolVersion and SslSupportMethod in AWS::CloudFront::Distribution ViewerCertificate. We are using the recommended SslSupportMethod of "sni-only" and MinimumProtocolVersion of "TLSv1.2_2018." Fixes: aws#9193 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
curtiseppel
pushed a commit
to curtiseppel/aws-cdk
that referenced
this pull request
Aug 11, 2020
… specifying distribution certificate (aws#9200) Per the CloudFormation documentation, if you specify an ACM certificate ARN, you must also specify values for MinimumProtocolVersion and SslSupportMethod in AWS::CloudFront::Distribution ViewerCertificate. We are using the recommended SslSupportMethod of "sni-only" and MinimumProtocolVersion of "TLSv1.2_2018." Fixes: aws#9193 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the CloudFormation documentation, if you specify an ACM certificate ARN, you must also specify values for
MinimumProtocolVersion and SslSupportMethod in AWS::CloudFront::Distribution ViewerCertificate. We are using
the recommended SslSupportMethod of "sni-only" and MinimumProtocolVersion of "TLSv1.2_2018."
Fixes: #9193
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license