Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cloudfront): Set MinimumProtocolVersion and SslSupportMethod when specifying distribution certificate #9200

Merged
merged 6 commits into from
Jul 22, 2020
Merged

fix(cloudfront): Set MinimumProtocolVersion and SslSupportMethod when specifying distribution certificate #9200

merged 6 commits into from
Jul 22, 2020
+47 −36

Commits on Jul 21, 2020

  1. fix(aws-cloudfront): Set MinimumProtocolVersion and SslSupportMethod … 

    …when specifying distribution certificate

Per the CloudFormation documentation, if you specify an ACM certificate ARN, you must also specify values for
MinimumProtocolVersion and SslSupportMethod in AWS::CloudFront::Distribution ViewerCertificate. We are using
the recommended SslSupportMethod of "sni-only" and default MinimumProtocolVersion of "TLSv1."

Fixes: #9193
    @tneely
    tneely committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    3f0e526 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2020

  1. Merge branch 'master' into tneely/fix-viewer-certificate-properties

    @tneely
    tneely committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    79942b1 View commit details
    Browse the repository at this point in the history

  2. Rename addViewerCertificate to renderViewerCertificate

    @tneely
    tneely committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    31e628f View commit details
    Browse the repository at this point in the history

  3. Use TLSv1.2_2018 by default

    @tneely
    tneely committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    10133a9 View commit details
    Browse the repository at this point in the history

  4. Move SSLMethod and SecurityPolicyProtocol enums to distribution.ts

    @tneely
    tneely committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    db52d95 View commit details
    Browse the repository at this point in the history

  5. Update minimum protocol version in readme

    @tneely
    tneely committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    a2f6581 View commit details
    Browse the repository at this point in the history