Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cfnInclude] Add support for Fn::Sub #9228

Closed
1 of 2 tasks
comcalvi opened this issue Jul 23, 2020 · 0 comments 路 Fixed by #9275
Closed
1 of 2 tasks

[cfnInclude] Add support for Fn::Sub #9228

comcalvi opened this issue Jul 23, 2020 · 0 comments 路 Fixed by #9275
Assignees
@comcalvi
Labels
@aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package effort/large Large work item 鈥撀爏everal weeks of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1
Milestone
[DevPreview] @aws...

Comments

@comcalvi
Copy link
Contributor

Fn::Sub is currently unsupported. It should be supported in both YAML and JSON.

Proposed Solution

I will be opening a PR to address this.

  • 馃憢 I may be able to implement this feature request
  • 鈿狅笍 This feature might incur a breaking change

This is a 馃殌 Feature Request
@comcalvi comcalvi added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 23, 2020
@skinny85 skinny85 added @aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package effort/large Large work item 鈥撀爏everal weeks of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Jul 23, 2020
@comcalvi comcalvi mentioned this issue Jul 27, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Jul 27, 2020
@mergify mergify bot closed this as completed in #9275 Jul 29, 2020
mergify bot pushed a commit that referenced this issue Jul 29, 2020
@comcalvi
feat(cfn-include): add support for the Fn::Sub function (#9275)
2a48495 
----

Closes  #9228 

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
curtiseppel pushed a commit to curtiseppel/aws-cdk that referenced this issue Aug 11, 2020
@comcalvi
feat(cfn-include): add support for the Fn::Sub function (aws#9275)
cf2594d 
----

Closes  aws#9228 

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@comcalvi comcalvi

Labels
@aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package effort/large Large work item 鈥撀爏everal weeks of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1
Projects
None yet
Milestone
[DevPreview] @aws-cdk/cloudformation-...
Development

Successfully merging a pull request may close this issue.

feat(cfn-include): add support for the Fn::Sub function comcalvi/aws-cdk
3 participants
@skinny85 @SomayaB @comcalvi