Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-codeguruprofiler] Add support for ComputePlatform property in a ProfilingGroup #9285

Closed
2 tasks
ivoanjo opened this issue Jul 28, 2020 · 1 comment · Fixed by #9391
Closed
2 tasks

[aws-codeguruprofiler] Add support for ComputePlatform property in a ProfilingGroup #9285

ivoanjo opened this issue Jul 28, 2020 · 1 comment · Fixed by #9391
Assignees
@skinny85
Labels
@aws-cdk/aws-codeguruprofiler Related to Amazon CodeGuru Profiler feature-request A feature should be added or improved. in-progress This issue is being actively worked on. needs-triage This issue or PR still needs to be triaged.

Comments

@ivoanjo
Copy link
Contributor

ivoanjo commented Jul 28, 2020

The CfnProfilingGroup is missing the ComputePlatform property which is available for the ProfilingGroup cloudformation resources.

Without it, it's not possible to create profiling groups for AWS Lambda.

Use Case

Create profiling groups for AWS Lambdas.

Other

I'm from the CodeGuru Profiler team, so do let us know if we can make your life better in any way, CDK folks! Also, thanks for the awesome tool --- all our backend cloudformation resources are written using CDK.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@ivoanjo ivoanjo added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 28, 2020
@github-actions github-actions bot added the @aws-cdk/aws-codeguruprofiler Related to Amazon CodeGuru Profiler label Jul 28, 2020
@SeekerWing SeekerWing mentioned this issue Aug 1, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Aug 3, 2020
@mergify mergify bot closed this as completed in #9391 Aug 14, 2020
mergify bot pushed a commit that referenced this issue Aug 14, 2020
@SeekerWing
feat(codeguruprofiler): add support for ComputePlatform in ProfilingG…
5a64bc5 
…roup (#9391)

fixes #9285


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@ivoanjo
Copy link
Contributor Author

ivoanjo commented Aug 14, 2020

Thank you @SeekerWing you're awesome! :)

@SeekerWing SeekerWing mentioned this issue Aug 14, 2020
Merged
mergify bot pushed a commit that referenced this issue Aug 17, 2020
@SeekerWing
fix(lambda): compute platform missing for autocreated profiling group (…
a8f4c9f 
…#9716)

follow up fix to #9285

currently the lambda construct provides support for profiling group creation via a boolean prop. however, the profiling group creation doesn't set the ComputePlatform value which is required to profile in lambda compute environment.

this PR explicitly sets the ComputePlatform when defining the profiling group in the Function construct. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-codeguruprofiler Related to Amazon CodeGuru Profiler feature-request A feature should be added or improved. in-progress This issue is being actively worked on. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(codeguruprofiler): add support for ComputePlatform in ProfilingGroup SeekerWing/aws-cdk
3 participants
@skinny85 @ivoanjo @SomayaB