Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[custom-resources] bug installing AWS SDK #9289

Closed
moltar opened this issue Jul 28, 2020 · 3 comments · Fixed by #9515
Closed

[custom-resources] bug installing AWS SDK #9289

moltar opened this issue Jul 28, 2020 · 3 comments · Fixed by #9515
Assignees
@eladb @jogold
Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p2

Comments

@moltar
Copy link
Contributor

moltar commented Jul 28, 2020

AwsCustomResource tries to install the latest SDK.

But it seems to be failing to install.

Yet it still works.

Reproduction Steps

Just use AwsCustomResource as documented.

Error Log

(I snipped some of the log)

---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
|   timestamp   |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          message                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          |
|---------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| 1595934621612 | START RequestId: 66eefc58-0f11-4b6b-9c83-9fde0436aa51 Version: $LATEST                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    |
| 1595934621615 | 2020-07-28T11:10:21.614Z 66eefc58-0f11-4b6b-9c83-9fde0436aa51 INFO Installing latest AWS SDK v2                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           |
| 1595934670297 | npm WARN enoent ENOENT: no such file or directory, open '/tmp/package.json'                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               |
| 1595934670297 | npm WARN tmp No description                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               |
| 1595934670297 | npm WARN tmp No repository field.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                         |
| 1595934670297 | npm WARN tmp No README data                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               |
| 1595934670297 | npm WARN tmp No license field.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            |
| 1595934670358 | /bin/sh: tree: command not found                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          |
| 1595934670377 | 2020-07-28T11:11:10.358Z 66eefc58-0f11-4b6b-9c83-9fde0436aa51 INFO Failed to install latest AWS SDK v2: Error: Command failed: tree /tmp/node_modules /bin/sh: tree: command not found                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    |
| 1595934674296 | 2020-07-28T11:11:14.296Z 66eefc58-0f11-4b6b-9c83-9fde0436aa51 INFO {"RequestType":"Create",...
| 1595934674296 | 2020-07-28T11:11:14.296Z 66eefc58-0f11-4b6b-9c83-9fde0436aa51 INFO AWS SDK VERSION: 2.631.0                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               |
| 1595934675415 | 2020-07-28T11:11:15.379Z 66eefc58-0f11-4b6b-9c83-9fde0436aa51 INFO Responding {"Status":"SUCCESS","Reason":"OK", ...
| 1595934675508 | END RequestId: 66eefc58-0f11-4b6b-9c83-9fde0436aa51                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       |
| 1595934675508 | REPORT RequestId: 66eefc58-0f11-4b6b-9c83-9fde0436aa51 Duration: 53895.13 ms Billed Duration: 53900 ms Memory Size: 128 MB Max Memory Used: 128 MB Init Duration: 138.05 ms                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               |
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Environment

  • **CLI Version : 1.54.0 (build c01b9b9)
  • Framework Version: 1.54.0
  • Node.js Version: v12.18.2
  • OS : macos
  • Language (Version): TypeScript

This is 🐛 Bug Report
@moltar moltar added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 28, 2020
@jogold
Copy link
Contributor

jogold commented Jul 28, 2020 •
edited

It works because it always falls back to the SDK available in the runtime.

This really weird tree change has been introduced in #8946 (16d2a48#diff-da2c71dd37423d1aef02bad867d86be7).

The simple fix is to revert this change. We can take this opportunity to also offer an opt out of this feature.

@SomayaB SomayaB changed the title [AwsCustomResource] bug installing AWS SDK [custom-resources] bug installing AWS SDK Jul 28, 2020
@github-actions github-actions bot added the @aws-cdk/custom-resources Related to AWS CDK Custom Resources label Jul 28, 2020
@moltar
Copy link
Contributor Author

moltar commented Jul 28, 2020

It seems like it was just added for development and forgotten.

Option out of updates would be a great feature and would speed up execution.

Thank you.

@eladb
Copy link
Contributor

eladb commented Jul 29, 2020

copy: @jogold

@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Jul 30, 2020
@eladb eladb added p2 effort/small Small work item – less than a day of effort labels Aug 4, 2020
@jogold jogold mentioned this issue Aug 4, 2020
Closed
jogold added a commit to jogold/aws-cdk that referenced this issue Aug 7, 2020
@jogold
feat(custom-resource): optional latest SDK installation for AwsCustom…
0656d68 
…Resource

Fix latest AWS SDK installation for `AwsCustomResource` and add option to
disable it.

Closes aws#9289
Closes aws#9322
@jogold jogold mentioned this issue Aug 7, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Aug 8, 2020
@mergify mergify bot closed this as completed in #9515 Aug 17, 2020
mergify bot pushed a commit that referenced this issue Aug 17, 2020
@jogold
feat(custom-resources): optional latest SDK installation for AwsCusto…
effdd3c 
…mResource (#9515)

Fix latest AWS SDK installation for `AwsCustomResource` and add option to
disable it.

Closes #9289
Closes #9322


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

@jogold jogold

Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(custom-resources): optional latest SDK installation for AwsCustomResource jogold/aws-cdk
4 participants
@moltar @eladb @jogold @SomayaB