Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[elasticloadbalancingv2] NetworkTargeGroup should inherit protocol from listener #9331

Closed
hoegertn opened this issue Jul 29, 2020 · 2 comments · Fixed by #9651
Closed

[elasticloadbalancingv2] NetworkTargeGroup should inherit protocol from listener #9331

hoegertn opened this issue Jul 29, 2020 · 2 comments · Fixed by #9651
Assignees
@rix0rrr
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on. p2

Comments

@hoegertn
Copy link
Contributor

If you create a network target group by using the addTargets method, the target group uses TCP as protocol instead of inheriting the protocol of the listener itself.

Reproduction Steps

Create new NetworkListener with TCP_UDP as protocol and call addTargets.

Error Log

You will see a protocol mismatch when deploying the app.

Environment

  • CLI Version : 1.55.0
  • Framework Version: 1.55.0
  • Node.js Version: v14
  • OS : macOS
  • Language (Version): Python

Other

[x] I can create a PR if you think this is valid.

This is 🐛 Bug Report
@hoegertn hoegertn added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 29, 2020
@github-actions github-actions bot added the @aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 label Jul 29, 2020
@ericzbeard ericzbeard assigned rix0rrr and unassigned ericzbeard Jul 30, 2020
@rix0rrr
Copy link
Contributor

rix0rrr commented Aug 4, 2020

That sounds perfectly sensible.

@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2 and removed bug This issue is a bug. labels Aug 4, 2020
@hoegertn
Copy link
Contributor Author

hoegertn commented Aug 4, 2020

Ok, I will open a PR. But I still think it is a bug because the resulting template is not deployable.

@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Aug 4, 2020
@hoegertn hoegertn mentioned this issue Aug 12, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Aug 13, 2020
@mergify mergify bot closed this as completed in #9651 Aug 18, 2020
mergify bot pushed a commit that referenced this issue Aug 18, 2020
@hoegertn
fix(elbv2): NLB Target Group does not inherit protocol (#9331) (#9651)
171ab59 
fixes #9331 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
misterjoshua pushed a commit to misterjoshua/aws-cdk that referenced this issue Aug 19, 2020
@hoegertn @misterjoshua
fix(elbv2): NLB Target Group does not inherit protocol (aws#9331) (aw…
ece1858 
…s#9651)

fixes aws#9331 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(elbv2): NLB Target Group does not inherit protocol (#9331)
4 participants
@rix0rrr @ericzbeard @hoegertn @SomayaB