Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cfn-include] Make CfnParameters mutable #9364

Closed
1 of 2 tasks
comcalvi opened this issue Jul 31, 2020 · 0 comments 路 Fixed by #9365
Closed
1 of 2 tasks

[cfn-include] Make CfnParameters mutable #9364

comcalvi opened this issue Jul 31, 2020 · 0 comments 路 Fixed by #9365
Assignees
@skinny85
Labels
@aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package feature-request A feature should be added or improved. in-progress This issue is being actively worked on. needs-triage This issue or PR still needs to be triaged.

Comments

@comcalvi
Copy link
Contributor

Currently, CfnParameters are not mutable once they are created.

Proposed Solution

I will be opening a PR to address this.

  • 馃憢 I may be able to implement this feature request
  • 鈿狅笍 This feature might incur a breaking change

This is a 馃殌 Feature Request
@comcalvi comcalvi added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 31, 2020
@github-actions github-actions bot added the @aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package label Jul 31, 2020
@comcalvi comcalvi mentioned this issue Jul 31, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Jul 31, 2020
@comcalvi comcalvi mentioned this issue Jul 31, 2020
Closed
@mergify mergify bot closed this as completed in #9365 Jul 31, 2020
mergify bot pushed a commit that referenced this issue Jul 31, 2020
@comcalvi
feat(core): make the CfnParameter class mutable (#9365)
860966a 
Closes #9364 

----

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
curtiseppel pushed a commit to curtiseppel/aws-cdk that referenced this issue Aug 11, 2020
@comcalvi
feat(core): make the CfnParameter class mutable (aws#9365)
38868d0 
Closes aws#9364 

----

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package feature-request A feature should be added or improved. in-progress This issue is being actively worked on. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
3 participants
@skinny85 @SomayaB @comcalvi