Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pipelines): CodeBuild images have (too) old Node version #9446

Merged
merged 2 commits into from
Aug 10, 2020

Conversation

justin8
Copy link
Contributor

@justin8 justin8 commented Aug 5, 2020

fixes #9070

This change moves CDK pipelines from standard build image 1.0 to 4.0


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

fixes aws#9070

This change moves CDK pipelines from standard build image 1.0 to 4.0
@SomayaB SomayaB changed the title fix(pipelines): support new versions of jest fix(cdk-pipelines): support new versions of jest Aug 5, 2020
@@ -1,11 +1,11 @@
import * as path from 'path';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a part of using --fix to clean up linting issues. It seems it had a bad import order throwing a warning beforehand anyway.

@rix0rrr rix0rrr changed the title fix(cdk-pipelines): support new versions of jest fix(pipelines): using CodeBuild images with a (too) old version of Node Aug 10, 2020
@rix0rrr rix0rrr changed the title fix(pipelines): using CodeBuild images with a (too) old version of Node fix(pipelines): CodeBuild images have (too) old Node version Aug 10, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 10, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 619067c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 10, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit bd45f34 into aws:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@aws-cdk/pipelines] Incorrect CodeBuild image used in default synth action
3 participants