-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): can't have multiple CfnRules in a Stack #9500
Conversation
@rix0rrr I know in #8251, we said we wanted to validate the names of the sections. But I think this story (#9485 ) shows that that was a mistake. For example, there's a new CFN template section, 'Hooks', used for ECS blue/green deployments. I don't think we should require a CDK update for the new section to be usable. Your thoughts? |
Mmyeah. It's a little scary to me, but I see your point. Let's try it this way. |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
When we changed the merging behavior in #8251, we forgot to account for the 'Rules' section. To prevent that error from happening again, let's default to merging objects without duplicates. Fixes #9485 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
When we changed the merging behavior in #8251,
we forgot to account for the 'Rules' section.
To prevent that error from happening again,
let's default to merging objects without duplicates.
Fixes #9485
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license