fix(codebuild): fails on using PR Events together with FILE_PATH filters in a FilterGroup #9725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h filter when event is push only, fixes #8867
…sing comma trails, fixes #8867
…by/aws-cdk into JaseKirby/fix-issue-8867
skinny85
previously requested changes
Aug 14, 2020
There was a problem hiding this comment.
Thanks a lot @JaseKirby !
Small comment around the tests, otherwise looks great!
| @@ -582,6 +582,36 @@ export = { | |||
|
|
|||
| test.done(); | |||
| }, | |||
| 'with GitHub source including PULL_REQUEST_CREATED Event and FILE_PATH filter'(test: Test) { | |||
There was a problem hiding this comment.
Can you change the below test instead? To show that it works now.
Comment on lines
1634
to
1644
| 'cannot have file path conditions if the Group contains any action other than PUSH'(test: Test) { | ||
| const filterGroup = codebuild.FilterGroup.inEventOf(codebuild.EventAction.PULL_REQUEST_CREATED, | ||
| codebuild.EventAction.PUSH); | ||
|
|
||
| test.throws(() => { | ||
| filterGroup.andFilePathIsNot('.*\\.java'); | ||
| }, /A file path condition cannot be added if a Group contains any event action other than PUSH/); | ||
|
|
||
| test.done(); | ||
| }, | ||
|
|
There was a problem hiding this comment.
Suggested change
| 'cannot have file path conditions if the Group contains any action other than PUSH'(test: Test) { | |
| const filterGroup = codebuild.FilterGroup.inEventOf(codebuild.EventAction.PULL_REQUEST_CREATED, | |
| codebuild.EventAction.PUSH); | |
| test.throws(() => { | |
| filterGroup.andFilePathIsNot('.*\\.java'); | |
| }, /A file path condition cannot be added if a Group contains any event action other than PUSH/); | |
| test.done(); | |
| }, | |
| 'can have FILE_PATH filters if the Group contains PUSH and PR_CREATED events'(test: Test) { | |
| codebuild.FilterGroup.inEventOf( | |
| codebuild.EventAction.PULL_REQUEST_CREATED, | |
| codebuild.EventAction.PUSH) | |
| .andFilePathIsNot('.*\\.java'); | |
| test.done(); | |
| }, |
skinny85
changed the title
skinny85
approved these changes
Aug 17, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove blocking validation on GitHub webhook file path filter when
eventisPUSHonly.Fixes #8867
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license