New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cloudfront): Update Suported Security Protocol enum and set TLS_V1_2_2019 as a default version #9738
fix(cloudfront): Update Suported Security Protocol enum and set TLS_V1_2_2019 as a default version #9738
Conversation
…1_2_2019 as a default version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! I added an update to the README as well.
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@njlynch thanks. 👍. How do we update official AWS docs? Do they have a repo I can issue a PR to? |
@robertd - Yes, you can open a PR to https://github.com/awsdocs/amazon-cloudfront-developer-guide. |
…1_2_2019 as a default version (aws#9738) Closes aws#9212 I believe that official CloudFormation docs and AWS Console are out of sync. ### [CloudFormation Docs](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-distribution-viewercertificate.html#cfn-cloudfront-distribution-viewercertificate-minimumprotocolversion): ![image](https://user-images.githubusercontent.com/31543/90306646-a13ae280-de8c-11ea-8438-be97f6cae804.png) ### AWS Console: ![image](https://user-images.githubusercontent.com/31543/90306601-312c5c80-de8c-11ea-9e7e-491374f324df.png) https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/secure-connections-supported-viewer-protocols-ciphers.html#secure-connections-supported-ciphers ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Closes #9212
I believe that official CloudFormation docs and AWS Console are out of sync.
CloudFormation Docs:
AWS Console:
https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/secure-connections-supported-viewer-protocols-ciphers.html#secure-connections-supported-ciphers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license