Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-appmesh] Cannot create gRPC or HTTP/2 routes for Virtual Router #9755

Closed
buzzsurfr opened this issue Aug 17, 2020 · 1 comment · Fixed by #11343
Closed

[aws-appmesh] Cannot create gRPC or HTTP/2 routes for Virtual Router #9755

buzzsurfr opened this issue Aug 17, 2020 · 1 comment · Fixed by #11343
Assignees
@skinny85
Labels
@aws-cdk/aws-appmesh Related to AWS App Mesh bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Comments

@buzzsurfr
Copy link

Cannot create a grpc or http2 route in VirtualRouter. RouteType does not have enum entries and logic is missing in RouteBaseProps.

Both gRPC and HTTP/2 are supported in AWS::AppMesh::Route RouteSpec.

Reproduction Steps

N/A

What did you expect to happen?

N/A

What actually happened?

N/A

Environment

  • CLI Version : 1.59.0 (build 1d082f4)
  • Framework Version: 1.59
  • Node.js Version: v13.12.0
  • OS : MacOS
  • Language (Version): typescript@3.9.7

Other

This is 🐛 Bug Report
@buzzsurfr buzzsurfr added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Aug 17, 2020
@github-actions github-actions bot added the @aws-cdk/aws-appmesh Related to AWS App Mesh label Aug 17, 2020
@ccfife ccfife mentioned this issue Aug 17, 2020
Open
9 tasks
@MrArnoldPalmer MrArnoldPalmer added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Aug 17, 2020
@SomayaB SomayaB assigned skinny85 and unassigned MrArnoldPalmer Aug 20, 2020
@dfezzie dfezzie mentioned this issue Nov 18, 2020
Merged
@mergify mergify bot closed this as completed in #11343 Nov 19, 2020
mergify bot pushed a commit that referenced this issue Nov 19, 2020
feat(appmesh): change Route's spec to a union-like class (#11343)
f0de91f 
Implements the same pattern `GatewayRoutes` use for defining protocol specific specs.

Adds GRPC and HTTP2 support to Routes which will resolve #9755

BREAKING CHANGE: changes Route's spec to a union-like class. RouteSpec is now defined using protocol variant static methods


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-appmesh Related to AWS App Mesh bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(appmesh): change Route's spec to a union-like class dfezzie/aws-cdk
3 participants
@skinny85 @buzzsurfr @MrArnoldPalmer