Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cfn-include): add support for retrieving Mapping objects from the template #9777

Merged
merged 2 commits into from Aug 19, 2020
Merged

feat(cfn-include): add support for retrieving Mapping objects from the template #9777

merged 2 commits into from Aug 19, 2020

Conversation

skinny85
Copy link
Contributor

Fixes #9711

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 17, 2020
@skinny85
Copy link
Contributor Author

Missing ReadMe changes - will add.

@njlynch njlynch mentioned this pull request Aug 18, 2020
Merged
@skinny85 skinny85 force-pushed the feat/cfn-include-get-mapping branch from c7c3801 to f6df396 Compare August 18, 2020 23:46
@skinny85 skinny85 requested a review from njlynch August 18, 2020 23:48
@mergify
Copy link
Contributor

mergify bot commented Aug 19, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 170e9a4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 19, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a038304 into aws:master Aug 19, 2020
misterjoshua pushed a commit to misterjoshua/aws-cdk that referenced this pull request Aug 19, 2020
@skinny85 @misterjoshua
feat(cfn-include): add support for retrieving Mapping objects from th…
6f6dd8b 
…e template (aws#9777)

Fixes aws#9711

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@skinny85 skinny85 deleted the feat/cfn-include-get-mapping branch August 19, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njlynch njlynch njlynch approved these changes

@shivlaks shivlaks Awaiting requested review from shivlaks

Assignees

@skinny85 skinny85

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cfn-include] Add support for retrieving Mapping objects from the template
3 participants
@skinny85 @aws-cdk-automation @njlynch