Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudfront): all origin access identities have identical names #9829

Merged
merged 2 commits into from Aug 19, 2020

Conversation

njlynch
Copy link
Contributor

@njlynch njlynch commented Aug 19, 2020

Replaces the single hard-coded value for the origin access identity comment
field with one that refernces the origin's ID.

fixes #9580


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Replaces the single hard-coded value for the origin access identity comment
field with one that refernces the origin's ID.

fixes #9580
@njlynch njlynch requested a review from a team August 19, 2020 11:29
@njlynch njlynch self-assigned this Aug 19, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 19, 2020
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick reminder to keep commit titles lower case (except when referring to a class name, property key or such) - https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md#step-4-commit

@nija-at nija-at added the pr/do-not-merge This PR should not be merged at this time. label Aug 19, 2020
@njlynch njlynch changed the title fix(cloudfront): All origin access identities have identical names fix(cloudfront): all origin access identities have identical names Aug 19, 2020
@njlynch njlynch removed the pr/do-not-merge This PR should not be merged at this time. label Aug 19, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 19, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 94046f1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 19, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ca79188 into master Aug 19, 2020
@mergify mergify bot deleted the njlynch/cf-oai-comment branch August 19, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cloudfront-origins] All origin access identities have identical names
3 participants