Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cfn-include] parameters don't work with nested stacks #9838

Closed
skinny85 opened this issue Aug 19, 2020 · 0 comments · Fixed by #9842
Closed

[cfn-include] parameters don't work with nested stacks #9838

skinny85 opened this issue Aug 19, 2020 · 0 comments · Fixed by #9842
Assignees
@skinny85
Labels
@aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1
Milestone
[DevPreview] @aws...

Comments

@skinny85
Copy link
Contributor

The parameters property in CfnIncludeProps doesn't work correctly when used in combination with the nestedStacks property.
@github-actions github-actions bot added the @aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package label Aug 19, 2020
@skinny85 skinny85 added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Aug 19, 2020
@skinny85 skinny85 removed their assignment Aug 19, 2020
@comcalvi comcalvi mentioned this issue Aug 19, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Aug 20, 2020
skinny85 added a commit to comcalvi/aws-cdk that referenced this issue Sep 1, 2020
@skinny85
fix(cfn-include): allow parameters to be replaced across nested stacks
70322dc 
Fixes aws#9838
@mergify mergify bot closed this as completed in #9842 Sep 2, 2020
@mergify mergify bot unassigned comcalvi Sep 2, 2020
mergify bot pushed a commit that referenced this issue Sep 2, 2020
@comcalvi
fix(cfn-include): allow parameters to be replaced across nested stacks (
9ea8d5c 
#9842)

Fixes #9838

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@skinny85 skinny85 self-assigned this Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1
Projects
None yet
Milestone
[DevPreview] @aws-cdk/cloudformation-...
Development

Successfully merging a pull request may close this issue.

fix(cfn-include): allow parameters to be replaced across nested stacks comcalvi/aws-cdk
3 participants
@skinny85 @SomayaB @comcalvi