feat(eks): managed nodegroup with custom AMI and launch template support #9881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Hi @iliapolo I am ready for the first round. |
2 tasks
eladb
previously requested changes
Sep 1, 2020
|
Ping |
|
Thanks for the review. WIP 👍 |
iliapolo
previously requested changes
Sep 8, 2020
mergify
bot
dismissed
iliapolo’s stale review
Pull request has been modified.
|
fixing the integ now |
|
@pahud Should i review again? |
Yes, should all resolved. Please check it out again. Thanks. |
pahud
commented
Sep 8, 2020
|
@iliapolo I'm ready. |
iliapolo
approved these changes
Sep 9, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
iliapolo
added
pr/do-not-merge
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LaunchTemplatefor the managed nodegroupsLaunchTemplateprop.vpcof Pinger is nowec2.IVpc1.16to1.17Closes: #9873
Closes: #9924
Note
At this moment we use the property override to make it work. When cfn spec is updated we can use
CfnNodeGroupto specify launch template natively, which should be backward-compatible with no breaking changes.Users will need to create
CfnLaunchTemplateresource and pass the resource as the property to the nodegroup untill we support the LaunchTemplate L2(#6734).TODO
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license