fix(route53): value is too long error for TXT records #9984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The solution is to split the record strings over 255 characters into multiple text strings within the same record. See https://aws.amazon.com/premiumsupport/knowledge-center/route53-resolve-dkim-text-record-error/ Fixes aws#8244
shivlaks
previously approved these changes
Aug 26, 2020
| }); | ||
| } | ||
| } | ||
|
|
||
| function formatTxt(string: string): string { |
There was a problem hiding this comment.
let's add a comment here to capture the intent/approach to deal with the constraint - mainly for posterity
maybe also a documentation link might be handy as well
shivlaks
approved these changes
Aug 27, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solution is to split the record strings over 255 characters into
multiple text strings within the same record.
See https://aws.amazon.com/premiumsupport/knowledge-center/route53-resolve-dkim-text-record-error/
Fixes #8244
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license