Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appsync): support query & mutation generation for code-first approach #9992

Merged
merged 105 commits into from
Aug 29, 2020

Conversation

BryanPan342
Copy link
Contributor

@BryanPan342 BryanPan342 commented Aug 26, 2020

Implemented methods in appsync.Schema to easily generate query/mutation fields, or bind an existing ObjectType as the top level query/mutation type.

Fixes: #9308
Fixes: #9310


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@BryanPan342 BryanPan342 changed the title feat(appsync): support easy query generation for code-first approach feat(appsync): support query & mutation generation for code-first approach Aug 28, 2020
@MrArnoldPalmer MrArnoldPalmer added the pr/do-not-merge This PR should not be merged at this time. label Aug 28, 2020
Copy link
Contributor

@MrArnoldPalmer MrArnoldPalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added pr/do-not-merge pending @shivlaks review.

Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! - left some minor comments to take a look at before dropping the do-not-merge

packages/@aws-cdk/aws-appsync/README.md Show resolved Hide resolved
packages/@aws-cdk/aws-appsync/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-appsync/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-appsync/lib/schema.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-appsync/lib/schema.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-appsync/lib/schema.ts Outdated Show resolved Hide resolved
@BryanPan342 BryanPan342 removed the pr/do-not-merge This PR should not be merged at this time. label Aug 29, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 0c84ab2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1ed119e into aws:master Aug 29, 2020
@BryanPan342 BryanPan342 deleted the query branch September 8, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-appsync Related to AWS AppSync contribution/core This is a PR that came from AWS.
Projects
None yet
4 participants