feat(aws-route53): L2 for alias record set #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
reviewed
Nov 9, 2018
clareliguori
changed the title
clareliguori
force-pushed
the
route53-alias-record
branch
2 times, most recently
from
47b64f5
to
6d04d98
Compare
clareliguori
force-pushed
the
route53-alias-record
branch
from
5bd64f4
to
da883d3
Compare
rix0rrr
approved these changes
Nov 12, 2018
| ] | ||
| }); | ||
|
|
||
| new route53.AliasRecord(zone, 'Alias', { |
There was a problem hiding this comment.
Ew, do records have to be constructed under the zone that they need to be created in?
That's not according to how we design most of the construct library. But the R53 library is quite old, so it makes sense that it's not up-to-date with the latest guidelines.
Not your problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alias record allows referring to the hosted domain either by ID (HostedZoneRef) or by name (string)
Supports pointing to ALB/NLB and CloudFront distribution for initial stab
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.