Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(aws-kms): Use back tickets in documentation #13155

Closed
wants to merge 7 commits into from

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Feb 19, 2021

Currently using single quotes truncates the documentation. See screenshot below.

Screen Shot 2021-02-19 at 7 15 31 AM


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Currently using semi quotes trancates the documentation
@gitpod-io
Copy link

gitpod-io bot commented Feb 19, 2021

@github-actions github-actions bot added the @aws-cdk/aws-kms Related to AWS Key Management label Feb 19, 2021
@michaelbrewer michaelbrewer changed the title docs(aws-kms): Add back tickets in documentation docs(aws-kms): Use back tickets in documentation Feb 19, 2021
Co-authored-by: Nick Lynch <nlynch@amazon.com>
njlynch
njlynch previously approved these changes Feb 22, 2021
@mergify
Copy link
Contributor

mergify bot commented Feb 22, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@njlynch
Copy link
Contributor

njlynch commented Feb 22, 2021

@michaelbrewer - Can you allow changes to be pushed to your fork (see above mergify comment)? Without that, we can't update from the base branch and merge.

@mergify mergify bot dismissed njlynch’s stale review February 22, 2021 12:38

Pull request has been modified.

@michaelbrewer
Copy link
Contributor Author

@michaelbrewer - Can you allow changes to be pushed to your fork (see above mergify comment)? Without that, we can't update from the base branch and merge.

That option is not available to me, see screenshot:

Screen Shot 2021-02-22 at 4 39 47 AM

@michaelbrewer
Copy link
Contributor Author

@michaelbrewer - Can you allow changes to be pushed to your fork (see above mergify comment)? Without that, we can't update from the base branch and merge.

This was forked from a team account : https://github.community/t/how-can-we-enable-allow-edits-from-maintainers-by-default/2847/11

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 8160fa0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@michaelbrewer
Copy link
Contributor Author

@iliapolo moving to : #13199

@michaelbrewer michaelbrewer deleted the docs-aws-kms branch April 24, 2021 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-kms Related to AWS Key Management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants