Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoscaling): AutoScale LaunchConfiguration MetadataOptions to configure IMDS V2 #14640

Closed
wants to merge 1 commit into from
Closed

feat(autoscaling): AutoScale LaunchConfiguration MetadataOptions to configure IMDS V2 #14640

wants to merge 1 commit into from

Conversation

erka
Copy link

@erka erka commented May 11, 2021

Added metadataOptions to allow configure IMDS V2 option for AutoScale LaunchConfiguration template #6977.

I know that EC2 LaunchTemplate should have similar settings so maybe MetadataOptions should be defined in ec2 module.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 11, 2021

@github-actions github-actions bot added the aws-cdk-lib Related to the aws-cdk-lib package label May 11, 2021
@mergify
Copy link
Contributor

mergify bot commented May 11, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@erka erka changed the title AutoScale LaunchConfiguration MetadataOptions to configure IMDS V2 feat: AutoScale LaunchConfiguration MetadataOptions to configure IMDS V2 May 11, 2021
@nija-at nija-at changed the title feat: AutoScale LaunchConfiguration MetadataOptions to configure IMDS V2 feat(autoscaling): AutoScale LaunchConfiguration MetadataOptions to configure IMDS V2 May 12, 2021
@nija-at nija-at removed the aws-cdk-lib Related to the aws-cdk-lib package label May 12, 2021
@nija-at nija-at removed their assignment May 12, 2021
@github-actions github-actions bot added the @aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling label May 12, 2021
@github-actions github-actions bot added the aws-cdk-lib Related to the aws-cdk-lib package label May 12, 2021
@nija-at nija-at removed the aws-cdk-lib Related to the aws-cdk-lib package label May 12, 2021
@nija-at nija-at removed their assignment May 12, 2021
@NetaNir NetaNir removed their assignment Jun 22, 2021
@itajaja
Copy link

itajaja commented Jun 28, 2021

any roadblock with this PR? I would like to have it set. If it's just a problem with linting, I can pick this up

@NetaNir NetaNir added the p1 label Jun 29, 2021
@NetaNir
Copy link
Contributor

NetaNir commented Jun 29, 2021

Thanks you for submitting this pull request. I am marking this pull request as p2, which means that we are unable to work on it immediately, but it's definitely still on our radar.

We use +1s to help prioritize our work, and are happy to revaluate this pull request based on community feedback. You can reach out to the cdk.dev community on Slack to solicit support for reprioritization.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 7cfc7ae
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ytsssun
Copy link

ytsssun commented Oct 21, 2021

+1 on this one. Any updates?

@erka
Copy link
Author

erka commented Oct 22, 2021

This feature was merged into upstream with different approach 2 days ago. Please checkout #16051 and #16052 for more details.

new autoscaling.AutoScalingGroup(stack, 'MyASG', {
  vpc,
  //....
  requireImdsv2: true,
});

@erka erka closed this Oct 22, 2021
@erka erka deleted the rd/autoscale-imdsv2 branch October 22, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants