feat(s3-deployment): enable efs support for handling large files in lambda

[keshav0891]

feat(s3-deployment): enable efs support for handling large files in lambda

It allows to attach EFS storage in worker lambda to handle large files upload;
Refactored unused imports

Verified that changes work by uploading large file (~350MB) using EFS support

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

Pull request has been modified.

[gMatas]

Hi there, just wanted to ask if there is any progress on this PR and its feature as I've been watching it for a while and noticed it has gone a bit stale.

[keshav0891]

Hi there, just wanted to ask if there is any progress on this PR and its feature as I've been watching it for a while and noticed it has gone a bit stale.

I am awaiting on reviewer to have bandwidth for review.

Pull request has been modified.

[iliapolo]

@keshav0891 Responded to your questions. Sorry the long delay.

[RomainMuller]

Some fairly minor notes left, but this is starting to look really good now!

Pull request has been modified.

[gMatas]

I've tried to make custom resource handler function dependent on the provided VPC, as suggested previously. This way InternetGateway and other VPC related resources were not destroyed before custom resource and its handler function do their magic.

function = S3LargeDeploymentFunction(
    scope,
    name=f'{name}Function',
    destination_bucket=destination_bucket,
    deployment_props=props,
    mount_path=mount_path,
    access_point=access_point
)

if props.vpc:
    function.node.add_dependency(props.vpc)

I've also added the line suggested by @RomainMuller:

if props.use_efs and props.vpc:
    file_system = self.__get_efs_filesystem(scope, props.vpc, props.efs_props or EfsProps())
    access_point = file_system.add_access_point(
        f'{name}FunctionAccessPoint',
        path=access_point_path,
        create_acl=Acl(
            owner_gid='1001',
            owner_uid='1001',
            permissions='0777'
        ),
        posix_user=PosixUser(
            gid='1001',
            uid='1001'
        )
    )

    access_point.node.add_dependency(file_system.mount_targets_available)

[keshav0891]

@gMatas
Thanks Mathew for the suggestion. I was able to resolve this too and the trick was to make VPC dependent on BucketDeployment instead of Lambda handler or EFS file system only.

if (props.vpc) {
  this.node.addDependency(props.vpc);
}

Will merge my changes for review soon.

Pull request has been modified.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: 1700908
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).