fix(ecs): Removing explicit mention of ECS DeploymentController for CircuitBreaker #16646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
kenilshah27
changed the title
kenilshah27
changed the title
RomainMuller
force-pushed
the
master
branch
from
924c117
to
ebfd5f2
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
peterwoodworth
changed the title
github-actions
bot
added
the
@aws-cdk/aws-ecs
|
@madeline-k I'm waiting for this PR to be merged ... |
|
Closing this PR as a duplicate of #16919. @enomotodev, I will review that one and focus on getting it merged instead of this one. |
1 similar comment
|
Closing this PR as a duplicate of #16919. @enomotodev, I will review that one and focus on getting it merged instead of this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECS service update with circuitbreaker via CDK was not as expected for the customer. The field DeploymentController is set to ECS when it is passed as null during creation. Now when we try to update the DeploymentCircuitBreaker field on the resource the value of ECS for DeploymentController is passed explicity. So technically this does not change anything on the service side except explicitly passing the value. But this is causing a new resource to be created via CFN as the field is createOnly. This leads to a new deploymment in ECS which should not happen as nothing is changing. This can cause issues for the customer side if they dont have enough instances to support new update causing failures and eventually failed updates via CDK.
Looking at the CDK implementation it seems like whenever the customer is creating/updating a service with CircuitBreaker the DeploymentConfiguration is explicitly set to ECS. This should not be the case because CircuitBreaker is independent of the DeploymentController and the validation for not supporting CircuitBreaker for any other DeploymentController is done on the backend. So this kind of explicit passing on value is not required in CDK.