Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elbv2): explicitly implement IApplicationTargetGroup #1806

Merged
merged 1 commit into from
Feb 22, 2019

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Feb 20, 2019

Fix usage of application and network target groups in languages
without structural typing, such as Java and C#.

Fixes #1799.


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Fix usage of application and network target groups in languages
without structural typing, such as Java and C#.

Fixes #1799.
@rix0rrr rix0rrr requested a review from a team as a code owner February 20, 2019 09:09
@rix0rrr rix0rrr self-assigned this Feb 20, 2019
@rix0rrr rix0rrr merged commit 828a2d7 into master Feb 22, 2019
@rix0rrr rix0rrr deleted the huijbers/interface-impl branch February 22, 2019 10:46
eladb pushed a commit that referenced this pull request Feb 26, 2019
Fix usage of application and network target groups in languages
without structural typing, such as Java and C#.

Fixes #1799.
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ApplicationTargetGroup doesn't implement IApplicationTargetGroup
3 participants