Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(elbv2): BaseLoadBalancer.vpc is not optional #18474

Merged
merged 3 commits into from
Jan 18, 2022
Merged

fix(elbv2): BaseLoadBalancer.vpc is not optional #18474

merged 3 commits into from
Jan 18, 2022

Commits on Jan 17, 2022

  1. fix(elbv2): BaseLoadBalancer.vpc is not optional 

    The `BaseLoadBalancer.vpc` property fulfills the `IApplicationLoadBalancer.vpc` and
`INetworkLoadBalancer.vpc` properties, both of which are optional. A bug in `jsii` (see aws/jsii#3342)
makes this pass type system consistency checks, when it should not be allowed.
    Romain Marcadier committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    f5a1bd6 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2022

  1. Update allowed-breaking-changes.txt

    Romain Marcadier committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    714ec11 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into rmuller/optional-vpc

    Romain Marcadier committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    049cdce View commit details
    Browse the repository at this point in the history