Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add eslint rule to forbid instanceof #20564

Closed
wants to merge 3 commits into from
Closed

chore: add eslint rule to forbid instanceof #20564

wants to merge 3 commits into from

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jun 1, 2022 •
edited

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr rix0rrr requested a review from a team June 1, 2022 07:42
@gitpod-io
Copy link

gitpod-io bot commented Jun 1, 2022

@github-actions github-actions bot added the p2 label Jun 1, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team June 1, 2022 07:42
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 1, 2022
@TheRealAmazonKendra TheRealAmazonKendra changed the base branch from v1-main to main June 2, 2022 09:01
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3fd6339
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@TheRealAmazonKendra TheRealAmazonKendra mentioned this pull request Aug 3, 2022
Closed
1 task
@TheRealAmazonKendra
Copy link
Contributor

I like this. Mind if I snag it and finish it?

@corymhall corymhall mentioned this pull request Dec 2, 2022
Merged
2 tasks
@kylelaker kylelaker mentioned this pull request Jan 4, 2023
Closed
This was referenced Feb 28, 2023
Merged
Closed
@rix0rrr
Copy link
Contributor Author

rix0rrr commented Mar 16, 2023

I give up.

@rix0rrr rix0rrr closed this Mar 16, 2023
@rix0rrr rix0rrr deleted the huijbers/no-instanceof branch March 16, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rix0rrr @aws-cdk-automation @TheRealAmazonKendra @Chriscbr