chore(pkglint): Add rule to specify repository.directory #2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used in `package.json` to denote the path of a module's root relative to the repository, so that links can be emitted to the correct location instead of the root of the repository. See: https://docs.npmjs.com/files/package.json#repository
RomainMuller
requested review from
skinny85,
SoManyHs and
a team
as code owners
eladb
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used in
package.jsonto denote the path of a module's rootrelative to the repository, so that links can be emitted to the correct
location instead of the root of the repository.
This leverages the functionality introduced/updated in aws/jsii#432
See: https://docs.npmjs.com/files/package.json#repository
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.