refactor(cx): typo in decryption policy #23298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decryption policy in contains a typo. In few places non-existing word `Descryption` is used. It is confusing, because it could mean either `Decryption` or `Description`. This resolves this by changing it to `Decryption`.
|
|
github-actions
bot
added
the
beginning-contributor
|
Thanks @kamil-forys that's very unfortunate because |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mrgrain
requested changes
Dec 9, 2022
| @@ -63,7 +63,7 @@ The following json shows the current recommended set of flags, as `cdk init` wou | |||
| "@aws-cdk/core:validateSnapshotRemovalPolicy": true, | |||
| "@aws-cdk/aws-codepipeline:crossAccountKeyAliasStackSafeResourceName": true, | |||
| "@aws-cdk/aws-s3:createDefaultLoggingPolicy": true, | |||
| "@aws-cdk/aws-sns-subscriptions:restrictSqsDescryption": true, | |||
| "@aws-cdk/aws-sns-subscriptions:restrictSqsDecryption": true, | |||
|
Closing due to inability of changing existing feature flag. |
|
@kamil-forys, please consider adding an additional feature flag for the same thing, but with the correct spelling. if both the old and new flags are present and set to different values; you could error instructing people to remove one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decryption policy in cx contains a typo.
In few places non-existing word
Descryptionis used. It is confusing, because it could mean eitherDecryptionorDescription. This resolves this by changing it toDecryption.All Submissions:
Adding new Construct Runtime Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license