Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(awslint): construct-base-is-private, resource-attribute #2349

Merged
merged 7 commits into from
May 1, 2019

Commits on Apr 22, 2019

  1. refactor(awslint): XxxReflection classes

    Implement a "Reflection" class for each rule family (modules, constructs, resources) which
    reflect on the type system and expose a relevant API for linter rules.
    
    The rational is that this increases our ability to reuse the model by other rule families.
    For example, the "ResourceReflection" extends "ConstructReflection" and adds more
    information that's specific to AWS resource constructs.
    Elad Ben-Israel committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    10b0665 View commit details
    Browse the repository at this point in the history
  2. full build passes

    Elad Ben-Israel committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    9bdadd5 View commit details
    Browse the repository at this point in the history
  3. update expectation

    Elad Ben-Israel committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    4e625b4 View commit details
    Browse the repository at this point in the history
  4. Hide more XxxBase classes

    add awslint:construct-base-is-private
    
    - eks.ClusterBase
    - codebuild.ProjectBase
    - codecommit.RepositoryBase
    - codedeploy.ServerDeploymentGroupBase
    - ecr.RepositoryBase
    - eks.ClusterBase
    - lambda.LayerVersionBase
    - rds.DatabaseClusterBase
    - secretsmanager.SecretBase
    - ses.ReceiptRuleSetBase
    
    - update "foreach.sh" to ignore undefined npm scripts
    - update contribution guide with instructions on how to use foreach.sh
    Elad Ben-Israel committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    3269e0c View commit details
    Browse the repository at this point in the history

Commits on May 1, 2019

  1. Merge remote-tracking branch 'origin/master' into benisrae/awslint-re…

    …factor
    Elad Ben-Israel committed May 1, 2019
    Configuration menu
    Copy the full SHA
    ebda84f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bce8a2d View commit details
    Browse the repository at this point in the history
  3. remove repository-ref.ts

    Elad Ben-Israel committed May 1, 2019
    Configuration menu
    Copy the full SHA
    d5012b1 View commit details
    Browse the repository at this point in the history