Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): allow cross region export provider to delete more than 10 exports #23969

Conversation

joshbalfour
Copy link

I found that if you remove more than 10 cross-region exports from your stack then the custom resource throws an error.
To fix this I am batching the deleteParameters SSM call into batches of 10.

Hopefully this aligns with your contribution guidelines, anything is amiss let me know and I'll be happy to change 😊

Closes #23958.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Feb 2, 2023

@github-actions github-actions bot added bug This issue is a bug. p2 labels Feb 2, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team February 2, 2023 14:31
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Feb 2, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@joshbalfour joshbalfour changed the title fix(@aws-cdk/core): allow cross region export provider to delete more than 10 exports fix(core): allow cross region export provider to delete more than 10 exports Feb 2, 2023
@joshbalfour
Copy link
Author

I'm happy to add an integration test for this, I think the best place for one would be adding a new test case here.

Please could someone point me to how I could write a test case that involves updating a stack? I couldn't find any examples.

Thanks!

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@joshbalfour
Copy link
Author

Clarification Request (see #23969 (comment))

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Feb 28, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7129a80
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@corymhall corymhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshbalfour sorry this took so long to get to! I really appreciate that you reported the issue and sent us a fix 😍.

I just have one very minor comment and then an idea on how to do the integration test and then we are good to go!

: [arr];
}

async function deleteParameters(ssm: SSM, names: string[]): Promise<void> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment here explaining why we are splitting it into groups of 10?


/**
* Test that if we delete more than 10 exports that the
* stack will update correctly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need to add a new integration test (new file and everything) since this test scenario will probably conflict with the one above.

To test this scenario you can probably do a very similar test to the one above, but just invert the scenario. Instead of deleting the producer stack, delete the consumer and then perform a describeStacks and expect the delete to have succeeded.

@TheRealAmazonKendra TheRealAmazonKendra removed the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Feb 28, 2023
@TheRealAmazonKendra
Copy link
Contributor

Removing request label since it looks like @corymhall provided the clarification needed. If you need any further clarification, please let us know.

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Mar 29, 2023
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@scanlonp
Copy link
Contributor

scanlonp commented Apr 11, 2024

Hey @joshbalfour, I'm going to pick this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CrossRegionExportWriter: Response object is too long.
5 participants